Store api key scopes in array column #4610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4610 +/- ##
=======================================
Coverage 97.09% 97.09%
=======================================
Files 392 393 +1
Lines 8259 8273 +14
=======================================
+ Hits 8019 8033 +14
Misses 240 240 ☔ View full report in Codecov by Sentry. |
Contributor
|
Is there any reason to use |
segiddins
force-pushed
the
segiddins/store-api-key-scopes-in-jsonb-column
branch
from
68e6256 to
41bf262
Compare
Contributor
Author
|
@simi changed to array of string |
segiddins
force-pushed
the
segiddins/store-api-key-scopes-in-jsonb-column
branch
from
41bf262 to
86bcf90
Compare
simi
reviewed
Apr 24, 2024
simi
approved these changes
Apr 24, 2024
simi
reviewed
Apr 24, 2024
segiddins
force-pushed
the
segiddins/store-api-key-scopes-in-jsonb-column
branch
from
86bcf90 to
48d8103
Compare
segiddins
force-pushed
the
segiddins/store-api-key-scopes-in-jsonb-column
branch
from
48d8103 to
a24f43e
Compare
simi
approved these changes
Apr 25, 2024
segiddins
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.