Subscription testing. #463

Closed
wants to merge 13 commits into
from

Conversation

Projects
None yet
3 participants
@cmeiklejohn
Contributor

cmeiklejohn commented Sep 10, 2012

Not ready to merge

This adds phantomjs for JavaScript testing, and adds a scenario for testing subscriptions.

Some outstanding issues:

  • the subscription steps need to sleep before the subscription will be gone -- I'm not sure if this is a database cache issue or not because it won't render the JavaScript until the record is gone. Further debugging is needed.
  • When entering/leaving a tagged javascript scenario, the database_cleaner attempts to switch strategies again (from truncation to truncation) which causes it to attempt to require the library again, which is causing activesupport to throw an error on getcwd (no clue). Further debugging is needed.

@ghost ghost assigned cmeiklejohn Sep 10, 2012

cmeiklejohn and others added some commits Feb 6, 2012

Remove app_host.
This wasn't really doing anything since we were using the local rack
instance.
Revert "Update cleaning strategy."
This reverts commit 645be7aabfe3b5bc9ea6e25fc9d28aff8de29c1a.
Fixes tests: resets current directory in gemcutter After block.
The Before was making a temp directory and chdir'ing into it and the
After was removing the temp directory, but it never changed back
out of the (now missing) temp directory. Subsequent tests failed
in the C `getcwd` function because CWD no longer existed.

Fixed with @jaredonline. Issue on branch #463.
Merge pull request #485 from mildmojo/subscription_steps_fixed
Fixes tests: resets current directory in gemcutter After block.
@qrush

This comment has been minimized.

Show comment Hide comment
@qrush

qrush Nov 28, 2014

Owner

Whoa, old PR and phantomjs integration. @cmeiklejohn I owe you a hug. I'm closing this.

Owner

qrush commented Nov 28, 2014

Whoa, old PR and phantomjs integration. @cmeiklejohn I owe you a hug. I'm closing this.

@qrush qrush closed this Nov 28, 2014

@qrush qrush deleted the subscription_steps branch Dec 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment