Allow creating API keys with an expiration date #4681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4681 +/- ##
=======================================
Coverage 97.09% 97.09%
=======================================
Files 392 392
Lines 8273 8275 +2
=======================================
+ Hits 8033 8035 +2
Misses 240 240 ☔ View full report in Codecov by Sentry. |
segiddins
force-pushed
the
segiddins/wip-allow-creating-api-keys-with-an-expiration-date
branch
from
050c66b to
56c4397
Compare
segiddins
force-pushed
the
segiddins/wip-allow-creating-api-keys-with-an-expiration-date
branch
2 times, most recently
from
264b4ba to
4275747
Compare
segiddins
changed the title
martinemde
force-pushed
the
segiddins/wip-allow-creating-api-keys-with-an-expiration-date
branch
from
4275747 to
5159c36
Compare
martinemde
approved these changes
May 7, 2024
Will be used for CLI workflow to add trusted publishing to a gem, since we dont want the resulting API key that can manage trusted publishing to be long-lived
segiddins
force-pushed
the
segiddins/wip-allow-creating-api-keys-with-an-expiration-date
branch
from
5159c36 to
de23d50
Compare
segiddins
deleted the
segiddins/wip-allow-creating-api-keys-with-an-expiration-date
branch
simi
reviewed
May 7, 2024
| <%= form_with model: [:profile, @api_key], data: { controller: "exclusive-checkbox gem-scope" } do |f| %> | ||
| <%= label_tag :name, t("api_keys.index.name"), class: "form__label" %> | ||
| <%= f.text_field :name, class: "form__input", autocomplete: :off %> | ||
| <%= f.text_field :name, class: "form__input", autocomplete: :off, disabled: f.object.persisted? %> |
Contributor
There was a problem hiding this comment.
Is name "readonly" once created? Is that enforced also on server side somehow?
Contributor
Author
There was a problem hiding this comment.
yes, enforced in the controllers and there are tests for that
Contributor
There was a problem hiding this comment.
Looking again, it seems covered by controller. Is that enough? What about model validation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be used for CLI workflow to add trusted publishing to a gem, since we dont want the resulting API key that can manage trusted publishing to be long-lived