Allow API keys valid for less than 15min total to skip MFA #4691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinemde
reviewed
May 8, 2024
Now that we allow creating API keys with a custom expiration time (that is immutable to users), we want to allow API keys made to be intentionally super short-lived to skip MFA This is useful for allowing a user to mint a single API token for 10 minutes and use it for multiple requests in that timeframe without needing to supply MFA on each request
segiddins
force-pushed
the
segiddins/allow-api-keys-valid-for-less-than-15min-total-to-skip-mfa
branch
from
7e5c9c4 to
f7a0559
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4691 +/- ##
==========================================
+ Coverage 97.10% 97.11% +0.01%
==========================================
Files 392 393 +1
Lines 8279 8326 +47
==========================================
+ Hits 8039 8086 +47
Misses 240 240 ☔ View full report in Codecov by Sentry. |
martinemde
approved these changes
May 8, 2024
segiddins
deleted the
segiddins/allow-api-keys-valid-for-less-than-15min-total-to-skip-mfa
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we allow creating API keys with a custom expiration time (that is immutable to users), we want to allow API keys made to be intentionally super short-lived to skip MFA
This is useful for allowing a user to mint a single API token for 10 minutes and use it for multiple requests in that timeframe without needing to supply MFA on each request