Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Issue #438 #474

Merged
merged 1 commit into from

2 participants

@jaredonline

There wasn't actually a real race condition, the test just wasn't using
the proper factory. Worked with @mildmojo on the ID and fix. Issue #438

@jaredonline jaredonline Issue #438
There wasn't actually a real race condition, the test just wasn't using
the proper factory. Worked with @mildmojo on the ID and fix.
cc4f726
@cmeiklejohn
Collaborator

+1 thank you so much!

@cmeiklejohn cmeiklejohn merged commit 713583e into rubygems:master
@cmeiklejohn cmeiklejohn referenced this pull request
Closed

Testing race condition #438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 4, 2012
  1. @jaredonline

    Issue #438

    jaredonline authored
    There wasn't actually a real race condition, the test just wasn't using
    the proper factory. Worked with @mildmojo on the ID and fix.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  test/functional/profiles_controller_test.rb
View
2  test/functional/profiles_controller_test.rb
@@ -19,7 +19,7 @@ class ProfilesControllerTest < ActionController::TestCase
context "on GET to show" do
setup do
@rubygems = (0..10).map do |n|
- create(:rubygem, :downloads => n * 100).tap do |rubygem|
+ create(:rubygem_with_downloads, :downloads => n * 100).tap do |rubygem|
create(:ownership, :rubygem => rubygem, :user => @user)
end
end.reverse
Something went wrong with that request. Please try again.