New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes download test for count/day over month boundary. #477

Merged
merged 1 commit into from Nov 4, 2012

Conversation

Projects
None yet
2 participants
@mildmojo
Contributor

mildmojo commented Nov 4, 2012

The download_test.rb test for getting counts by day for a date range
was calling the method with strings instead of date objects. Actual
code uses dates. Changed the test to use dates so date arithmetic
is reliable. Fixed with @jaredonline. Issue #465.

Fixes download test for count/day over month boundary.
The download_test.rb test for getting counts by day for a date range
was calling the method with strings instead of date objects. Actual
code uses dates. Changed the test to use dates so date arithmetic
is reliable. Fixed with @jaredonline. Issue #465.
@cmeiklejohn

This comment has been minimized.

Show comment
Hide comment
@cmeiklejohn

cmeiklejohn Nov 4, 2012

Contributor

🍻

Contributor

cmeiklejohn commented Nov 4, 2012

🍻

cmeiklejohn added a commit that referenced this pull request Nov 4, 2012

Merge pull request #477 from mildmojo/fix_download_test_465
Fixes download test for count/day over month boundary.

@cmeiklejohn cmeiklejohn merged commit da5e69e into rubygems:master Nov 4, 2012

1 check passed

default The Travis build passed
Details

cmeiklejohn added a commit that referenced this pull request Jan 29, 2015

Merge pull request #477 from mildmojo/fix_download_test_465
Fixes download test for count/day over month boundary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment