New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pushed gems count to profiles #478

Merged
merged 4 commits into from Nov 4, 2012

Conversation

Projects
None yet
2 participants
@MarkBennett
Contributor

MarkBennett commented Nov 4, 2012

This address issue #261 by adding a count of the users pushed gems beside their email link.

It handles singular and plural counts of gems. ("1 gem" / "2 gems")

Screenshot:

5 gems

Thanks to @adkron for some design tips.

MarkBennett added some commits Nov 4, 2012

User#total_rubygems_count
This will be used to show the total number of pushed gems on the users profile.
Confirm sandworm gem appears on profile.
This was missed previously but should appear on the profile.
@cmeiklejohn

This comment has been minimized.

Show comment
Hide comment
@cmeiklejohn

cmeiklejohn Nov 4, 2012

Contributor

Fantastic, thank you so much!

Contributor

cmeiklejohn commented Nov 4, 2012

Fantastic, thank you so much!

cmeiklejohn added a commit that referenced this pull request Nov 4, 2012

Merge pull request #478 from MarkBennett/261-add-pushed-gems-count-to…
…-profiles

Add pushed gems count to profiles

@cmeiklejohn cmeiklejohn merged commit 43e43f4 into rubygems:master Nov 4, 2012

1 check passed

default The Travis build passed
Details

cmeiklejohn added a commit that referenced this pull request Jan 29, 2015

Merge pull request #478 from MarkBennett/261-add-pushed-gems-count-to…
…-profiles

Add pushed gems count to profiles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment