New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add per gem rss feed #479

Merged
merged 1 commit into from Nov 28, 2012

Conversation

Projects
None yet
6 participants
@amateurhuman
Contributor

amateurhuman commented Nov 4, 2012

Add an atom feed for version list of an individual gem. Allows user to subscribe to version changes without registering (by subscribing with an rss reader).

Fixes #466

@@ -27,6 +27,7 @@
<%= documentation_link(@latest_version, @rubygem.linkset) %>
<%= subscribe_link(@rubygem) if @latest_version.indexed %>
<%= unsubscribe_link(@rubygem) %>
<%= atom_link(@rubygem) %>

This comment has been minimized.

@grosser

grosser Nov 4, 2012

if you also put it into the header the browser can show it in the url-bar rss dropdown

@grosser

grosser Nov 4, 2012

if you also put it into the header the browser can show it in the url-bar rss dropdown

@grosser

This comment has been minimized.

Show comment
Hide comment
@grosser

grosser Nov 4, 2012

Some kind of test like 'it renders versions via atom' would be nice so the code gets at least executed once

grosser commented Nov 4, 2012

Some kind of test like 'it renders versions via atom' would be nice so the code gets at least executed once

@grosser

View changes

Show outdated Hide outdated app/views/versions/index.atom.builder Outdated
@cmeiklejohn

This comment has been minimized.

Show comment
Hide comment
@cmeiklejohn

cmeiklejohn Nov 4, 2012

Contributor

Can we add a test to this?

Contributor

cmeiklejohn commented Nov 4, 2012

Can we add a test to this?

@cmeiklejohn cmeiklejohn closed this Nov 4, 2012

@cmeiklejohn

This comment has been minimized.

Show comment
Hide comment
@cmeiklejohn

cmeiklejohn Nov 4, 2012

Contributor

Oops, didn't mean to close. Hit the wrong button.

Contributor

cmeiklejohn commented Nov 4, 2012

Oops, didn't mean to close. Hit the wrong button.

@cmeiklejohn cmeiklejohn reopened this Nov 4, 2012

@qrush

This comment has been minimized.

Show comment
Hide comment
@qrush

qrush Nov 7, 2012

Member

I am -1 until we have at least a functional test for this.

Member

qrush commented Nov 7, 2012

I am -1 until we have at least a functional test for this.

@amateurhuman

This comment has been minimized.

Show comment
Hide comment
@amateurhuman

amateurhuman Nov 7, 2012

Contributor

Agreed, it is in the works (with a few other tweaks) but got swamped with a couple conference talks this week. Planning on wrapping this later in the week.

Contributor

amateurhuman commented Nov 7, 2012

Agreed, it is in the works (with a few other tweaks) but got swamped with a couple conference talks this week. Planning on wrapping this later in the week.

@amateurhuman

This comment has been minimized.

Show comment
Hide comment
@amateurhuman

amateurhuman Nov 8, 2012

Contributor

Added functional test for the feed, also replaced the hand formated updated string with the Ruby stdlib iso8601 method which was suggested by @pjg

There is a lot of duplication with the index and feed builder, but I haven't spent any time looking at drying that up (I'd say its probably a second issue). Let me know if you'd prefer the refactor now.

Contributor

amateurhuman commented Nov 8, 2012

Added functional test for the feed, also replaced the hand formated updated string with the Ruby stdlib iso8601 method which was suggested by @pjg

There is a lot of duplication with the index and feed builder, but I haven't spent any time looking at drying that up (I'd say its probably a second issue). Let me know if you'd prefer the refactor now.

@adkron

This comment has been minimized.

Show comment
Hide comment
@adkron

adkron Nov 9, 2012

Contributor

I think it is easier to DRY it up while you are thinking about it.

Contributor

adkron commented Nov 9, 2012

I think it is easier to DRY it up while you are thinking about it.

Add atom link for single gem versions feed
Add atom builder for single gem version

Add styles for rss link

Add yield head for injecting atom feed link

Include link tag in head for rss feed

Add gem name to feed title, add test for atom feed

Use ruby stdlib iso8601 method instead of hand formatted

Refactor individual and all versions feeds to share some builder partial
@amateurhuman

This comment has been minimized.

Show comment
Hide comment
@amateurhuman

amateurhuman Nov 12, 2012

Contributor

Alright, the Latest Versions feeds for both individual gems and the site-wide feed are sharing the same builder partial. I think that completes everyone's suggestions, so I've rebased and squashed all the changes into a single commit.

Contributor

amateurhuman commented Nov 12, 2012

Alright, the Latest Versions feeds for both individual gems and the site-wide feed are sharing the same builder partial. I think that completes everyone's suggestions, so I've rebased and squashed all the changes into a single commit.

@grosser

This comment has been minimized.

Show comment
Hide comment
@grosser

grosser commented Nov 12, 2012

👍

adkron added a commit that referenced this pull request Nov 28, 2012

@adkron adkron merged commit 2e70398 into rubygems:master Nov 28, 2012

1 check passed

default The Travis build passed
Details

adkron added a commit that referenced this pull request Jan 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment