New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove librato.yml containing API credentials #480

Merged
merged 1 commit into from Nov 7, 2012

Conversation

Projects
None yet
4 participants
@Umofomia
Contributor

Umofomia commented Nov 4, 2012

Remove librato.yml containing API credentials; introduce example file in its stead.

@sferik: Replace your credentials since they're now public.

@Umofomia

This comment has been minimized.

Show comment
Hide comment
@Umofomia

Umofomia Nov 4, 2012

Contributor

FYI, it looks like the current Travis build failure is due to issue #438.

Contributor

Umofomia commented Nov 4, 2012

FYI, it looks like the current Travis build failure is due to issue #438.

@Umofomia

This comment has been minimized.

Show comment
Hide comment
@Umofomia

Umofomia Nov 4, 2012

Contributor

Now that #438 has been fixed, Travis build has passed.

Contributor

Umofomia commented Nov 4, 2012

Now that #438 has been fixed, Travis build has passed.

@Skipants

This comment has been minimized.

Show comment
Hide comment
@Skipants

Skipants Nov 4, 2012

+1. This will also fix dev - librato is failing on dev because there's no development variables in this config file.

Skipants commented Nov 4, 2012

+1. This will also fix dev - librato is failing on dev because there's no development variables in this config file.

@adkron

This comment has been minimized.

Show comment
Hide comment
@adkron

adkron Nov 6, 2012

Contributor

This is a great idea, and keeps the creds out of the public eye. +1 ready to commit.

Contributor

adkron commented Nov 6, 2012

This is a great idea, and keeps the creds out of the public eye. +1 ready to commit.

qrush added a commit that referenced this pull request Nov 7, 2012

Merge pull request #480 from Umofomia/remove-librato-yml
Remove librato.yml containing API credentials

@qrush qrush merged commit 1f9ab5b into rubygems:master Nov 7, 2012

1 check passed

default The Travis build passed
Details

qrush added a commit that referenced this pull request Jan 29, 2015

Merge pull request #480 from Umofomia/remove-librato-yml
Remove librato.yml containing API credentials
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment