Disallow gem names with caps #481

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants
@coffeencoke

Extension of #451 for issue #421 - adds a test to ensure a gem can be saved with CAPS in the name when it already exists.

@adkron

This comment has been minimized.

Show comment
Hide comment
@adkron

adkron Nov 6, 2012

Contributor

Merging this in allows us to close this #421, #481, and pull request #451. Looks good to go to me.

Contributor

adkron commented Nov 6, 2012

Merging this in allows us to close this #421, #481, and pull request #451. Looks good to go to me.

@qrush

This comment has been minimized.

Show comment
Hide comment
@qrush

qrush Nov 7, 2012

Member

Holy moley! This is a BIGGIE!

Hey @evanphx @drbrain are we good to merge/deploy this? We've been talking about it forever.

Member

qrush commented Nov 7, 2012

Holy moley! This is a BIGGIE!

Hey @evanphx @drbrain are we good to merge/deploy this? We've been talking about it forever.

@evanphx

This comment has been minimized.

Show comment
Hide comment
@evanphx

evanphx Nov 7, 2012

Member

I'd prefer to be use case insensitive to detect gems but use case preserve for any new gems. This change appears to prevent all future gems from having capital letters, which I think is the wrong way to go.

Member

evanphx commented Nov 7, 2012

I'd prefer to be use case insensitive to detect gems but use case preserve for any new gems. This change appears to prevent all future gems from having capital letters, which I think is the wrong way to go.

@adkron

This comment has been minimized.

Show comment
Hide comment
@adkron

adkron Nov 7, 2012

Contributor

👍 to @evanphx's idea. It seems like it would be a much smaller change too.

Contributor

adkron commented Nov 7, 2012

👍 to @evanphx's idea. It seems like it would be a much smaller change too.

@adkron

This comment has been minimized.

Show comment
Hide comment
@adkron

adkron Nov 28, 2012

Contributor

@coffeencoke Do you want to make the changes to this to implement case preserving names, and case insensitive gem detection?

Contributor

adkron commented Nov 28, 2012

@coffeencoke Do you want to make the changes to this to implement case preserving names, and case insensitive gem detection?

@evanphx

This comment has been minimized.

Show comment
Hide comment
@evanphx

evanphx Jul 12, 2013

Member

No movement, closing.

Member

evanphx commented Jul 12, 2013

No movement, closing.

@evanphx evanphx closed this Jul 12, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment