Rename Rubygem(s) to gem(s) in pagination #529

Merged
merged 1 commit into from Feb 12, 2013

Projects

None yet

3 participants

Contributor
joonty commented Feb 12, 2013

In both the gem index and search, the text "Displaying all x Rubygems"
is now "Displaying all x gems". will_paginate pluralizes it when
appropriate.

Also added assertions to existing tests in the rubygems and searches
controller test cases.

@joonty joonty Rename Rubygem(s) to gem(s) in pagination
In both the gem index and search, the text "Displaying all x Rubygems"
is now "Displaying all x gems". will_paginate pluralizes it when
appropriate.

Also added assertions to existing tests in the rubygems and searches
controller test cases.
bed8244
@sferik sferik merged commit d0843cb into rubygems:master Feb 12, 2013

1 check passed

default The Travis build passed
Details
Contributor

How did this get accepted with a tabbing mistake?

Member
sferik commented Feb 13, 2013

Oh, the horror! 🙀

Fixed in cf9c825.

Thanks for sweating the small stuff.

Contributor

Right, if you let little mistakes like that slip by, I wonder what other mistakes you would let slip.

@joonty joonty deleted the joonty:better_paginated_name branch Feb 13, 2013
Contributor
joonty commented Feb 13, 2013

Oh dear Lord!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment