Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Use placeholder in search box #538

Merged
merged 2 commits into from Mar 3, 2013

Conversation

Projects
None yet
3 participants
Contributor

benhamill commented Mar 2, 2013

Would y'all be amenable to a pull request that changed the search box in the header section of the site to use placeholder? Right now, it sets a value of "Search gems..." and I guess use JavaScript to remove it on focus or whatever. I've seen, a couple of times, that the text didn't go away on focus and, well, that's what placeholder is for. I haven't dived into the code, but it seems like it'd be a simple change in the template, probably. I don't know about ripping out whatever JS is driving the rest. Thoughts?

Member

sferik commented Mar 1, 2013

Sounds good to me. Feel free to submit a patch.

Contributor

benhamill commented Mar 2, 2013

A commit. I couldn't see if there was JavaScript that interacted with the input or what. Feedback?

Contributor

benhamill commented Mar 2, 2013

Oooooh. It keys off "query". Thanks. I'll look at it. 😄

@sferik sferik added a commit that referenced this pull request Mar 3, 2013

@sferik sferik Merge pull request #538 from benhamill/placeholder_in_search
Use placeholder in search box
7cd9a6c

@sferik sferik merged commit 7cd9a6c into rubygems:master Mar 3, 2013

1 check passed

default The Travis build passed
Details

@sferik sferik added a commit that referenced this pull request Jan 29, 2015

@sferik sferik Merge pull request #538 from benhamill/placeholder_in_search
Use placeholder in search box
289c080
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment