[feature] List reverse dependencies for a specific gem #540

Merged
merged 6 commits into from Mar 25, 2013

Conversation

Projects
None yet
4 participants
@alup
Contributor

alup commented Mar 5, 2013

I implemented some new API methods to add the ability for reverse dependency fetching. Specifically, I have added a model helper called "rdepends" (in both 'Version' and 'Rubygem' models) to query the database for all the reverse dependencies of a specific gem. The helpers are exposed through API methods in api/v1/{version,rubygems} controllers. I have also included tests covering the new code pieces.

My idea is to implement (in both server and client side) a functionality similar to apt-rdepends -r utility. A user will be able to provide a name of a gem and the rubygems will return a list of all the reverse dependencies related to the name given. So, the next step would be to implement the client side part in rubygems library (or in bundler gem).

@alup

This comment has been minimized.

Show comment Hide comment
@alup

alup Mar 6, 2013

Contributor

@evanphx @sferik any thoughts on this? :)

Contributor

alup commented Mar 6, 2013

@evanphx @sferik any thoughts on this? :)

@sferik

This comment has been minimized.

Show comment Hide comment
@sferik

sferik Mar 6, 2013

Member

I've wanted this feature for a long time (see #123). Thanks for submitting the pull request.

My only question is about the name rdepends. I'd prefer the unabbreviated reverse_dependencies.

Member

sferik commented Mar 6, 2013

I've wanted this feature for a long time (see #123). Thanks for submitting the pull request.

My only question is about the name rdepends. I'd prefer the unabbreviated reverse_dependencies.

@alup

This comment has been minimized.

Show comment Hide comment
@alup

alup Mar 6, 2013

Contributor

@sferik Done :)!!! Fixed all references.

Contributor

alup commented Mar 6, 2013

@sferik Done :)!!! Fixed all references.

@alup

This comment has been minimized.

Show comment Hide comment
@alup

alup Mar 7, 2013

Contributor

@sferik Is there anything else that should be fixed?

Contributor

alup commented Mar 7, 2013

@sferik Is there anything else that should be fixed?

@evanphx

This comment has been minimized.

Show comment Hide comment
@evanphx

evanphx Mar 7, 2013

Member

👍

Member

evanphx commented Mar 7, 2013

👍

@alup

This comment has been minimized.

Show comment Hide comment
@alup

alup Mar 11, 2013

Contributor

@sferik @evanphx what else to be merged?

Contributor

alup commented Mar 11, 2013

@sferik @evanphx what else to be merged?

@fotos

This comment has been minimized.

Show comment Hide comment
@fotos

fotos Mar 19, 2013

👍 merge this please!

fotos commented Mar 19, 2013

👍 merge this please!

sferik added a commit that referenced this pull request Mar 25, 2013

Merge pull request #540 from alup/master
[feature] List reverse dependencies for a specific gem

@sferik sferik merged commit 4716713 into rubygems:master Mar 25, 2013

1 check passed

default The Travis build passed
Details
@sferik

This comment has been minimized.

Show comment Hide comment
@sferik

sferik Mar 25, 2013

Member

@alup Thanks again for submitting this pull request.

Now that it's merged, would you be willing to add the new API method to the gems gem? This should make it easier for Rubyists to use.

Member

sferik commented Mar 25, 2013

@alup Thanks again for submitting this pull request.

Now that it's merged, would you be willing to add the new API method to the gems gem? This should make it easier for Rubyists to use.

@alup

This comment has been minimized.

Show comment Hide comment
@alup

alup Mar 25, 2013

Contributor

@sferik thnx mate! I will add the API method, soon.

Contributor

alup commented Mar 25, 2013

@sferik thnx mate! I will add the API method, soon.

@alup alup referenced this pull request in rubygems/gems Mar 25, 2013

Merged

Command for reverse_dependencies #6

@sferik

This comment has been minimized.

Show comment Hide comment
@sferik

sferik Apr 17, 2013

Member

Unfortunately, this code runs incredibly 🐌 in production, to the extent that most requests to this endpoint are timing out.

It does not seem to be a problem if you include short=true in the request. Perhaps we should disable the non-short option for now?

Member

sferik commented Apr 17, 2013

Unfortunately, this code runs incredibly 🐌 in production, to the extent that most requests to this endpoint are timing out.

It does not seem to be a problem if you include short=true in the request. Perhaps we should disable the non-short option for now?

@alup

This comment has been minimized.

Show comment Hide comment
@alup

alup Apr 17, 2013

Contributor

@sferik Yes :S needs some refinements, maybe some caching ... For now, I agree we should disable the long output and only use the short one.

Contributor

alup commented Apr 17, 2013

@sferik Yes :S needs some refinements, maybe some caching ... For now, I agree we should disable the long output and only use the short one.

sferik added a commit that referenced this pull request Jan 29, 2015

Merge pull request #540 from alup/master
[feature] List reverse dependencies for a specific gem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment