Remove the forwarded and x-forwarded-host headers#5409
Merged
segiddins merged 1 commit intoJan 24, 2025
Merged
Conversation
We are already setting the Host header properly in the request to the rails app Prevents malicious redirects & their being cached Signed-off-by: Samuel Giddins <segiddins@segiddins.me>
martinemde
approved these changes
Jan 24, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5409 +/- ##
=======================================
Coverage 97.06% 97.06%
=======================================
Files 451 451
Lines 9391 9391
=======================================
Hits 9115 9115
Misses 276 276 ☔ View full report in Codecov by Sentry. |
segiddins
deleted the
segiddins/remove-the-forwarded-and-x-forwarded-host-headers
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are already setting the Host header properly in the request to the rails app
Prevents malicious redirects & their being cached
Signed-off-by: Samuel Giddins segiddins@segiddins.me