New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add change log links to gem page #728

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
@olivierlacan
Copy link
Contributor

olivierlacan commented Nov 5, 2014

This adds a new changelog column to the linksets table and displays
that change log alongside the existing linkset links.

image

This is a draft, there may be tests we haven't thought of updating with @jaymcgavren but we will if necessary.

Fixes #578

@olivierlacan olivierlacan force-pushed the olivierlacan:add-changelog-link branch 2 times, most recently Nov 5, 2014

@olivierlacan olivierlacan force-pushed the olivierlacan:add-changelog-link branch Nov 5, 2014

@evanphx

This comment has been minimized.

Copy link
Member

evanphx commented Nov 5, 2014

Where is the changelog value pulled from though? I don't see how it's set.

@olivierlacan

This comment has been minimized.

Copy link
Contributor

olivierlacan commented Nov 5, 2014

@evanphx It's not being pulled from anywhere at the moment since it would need to be a new gemspec key. But there's still this gem edit page I had no idea about: https://github.com/rubygems/rubygems.org/blob/master/app/views/rubygems/edit.html.erb

@dwradcliffe

This comment has been minimized.

Copy link
Member

dwradcliffe commented Nov 5, 2014

Based on the other PRs in progress, it sounds like editing via the website was going to be discouraged. Given that, should this new link only pull from the gemspec? Just a thought.

@olivierlacan

This comment has been minimized.

Copy link
Contributor

olivierlacan commented Nov 5, 2014

@dwradcliffe Sounds like a reasonable thing to do. I was amazed it's possible to override Linkset values, that said I don't think there's an active route for that gem edit page. Could be wrong.

This PR doesn't pull from anything, it's just ready to receive a new key as long as the key is named changelog.

@evanphx

This comment has been minimized.

Copy link
Member

evanphx commented Nov 5, 2014

@olivierlacan There doesn't need to be a new gemspec key. The code can use the metadata keys. We're generally not adding any new gemspec fields.

@dwradcliffe

This comment has been minimized.

Copy link
Member

dwradcliffe commented Nov 5, 2014

@olivierlacan There is an active route to edit gems (

resources :rubygems, :path => 'gems', :only => [:show, :edit, :update] do
) so that template would be used.

@qrush qrush added the feature label Nov 28, 2014

@kbrock

This comment has been minimized.

Copy link
Contributor

kbrock commented Jan 2, 2015

👍 to adding it to the metadata

@igrep

This comment has been minimized.

Copy link

igrep commented Jan 3, 2015

👍 I expect this feature to be merged! It'll make much easier to see a new version's change before updating the gem. 🙏

@olivierlacan

This comment has been minimized.

Copy link
Contributor

olivierlacan commented Jan 7, 2015

Makes sense to me. Will update soon.

@kbrock

This comment has been minimized.

Copy link
Contributor

kbrock commented Jan 8, 2015

@olivierlacan when this merges, can you double check that #724 adds changelog_uri key?

OTOH, if #724 goes through first, I will ping you so you can add the changelog_uri key to the new metadata hash.

@arthurnn arthurnn force-pushed the rubygems:master branch from e06276c to 821a975 Jan 29, 2015

@davefp

This comment has been minimized.

Copy link
Contributor

davefp commented Feb 4, 2015

@olivierlacan As a result of #610 a large chunk of the repo's history was re-written. Please rebase your PR so that it will merge cleanly. Thanks!

(There are further details on the blog: http://blog.rubygems.org/2015/02/01/rewriting-history.html)

@kbrock

This comment has been minimized.

Copy link
Contributor

kbrock commented Feb 9, 2015

After 724 goes through, I'll rebase this one.

@olivierlacan

This comment has been minimized.

Copy link
Contributor

olivierlacan commented Nov 9, 2015

@kbrock I'm going to entirely re-commit this PR with master so I can make it easily mergeable into #724 when that's done.

@olivierlacan olivierlacan force-pushed the olivierlacan:add-changelog-link branch Nov 9, 2015

@kbrock

This comment has been minimized.

Copy link
Contributor

kbrock commented Nov 9, 2015

@olivierlacan I was thinking that we would not add changelog in the form. Just read it out of the meta-data.

I think it would be great if the gemspec were the source for all gem metadata. Did you have something similar in mind?

@olivierlacan

This comment has been minimized.

Copy link
Contributor

olivierlacan commented Nov 9, 2015

@kbrock Oh yeah, my bad. I'll nix that.

@olivierlacan olivierlacan force-pushed the olivierlacan:add-changelog-link branch Nov 9, 2015

@olivierlacan

This comment has been minimized.

Copy link
Contributor

olivierlacan commented Nov 9, 2015

@kbrock Just force-pushed a removal of the edit changelog input in the form.

@arthurnn arthurnn referenced this pull request Nov 28, 2015

Closed

Move metadata from Linkset(rubygems.org table) to gemspec #1127

4 of 4 tasks complete
Add change log links to gem page
This adds a new changelog column to the linksets table and displays
that change log alongside the existing linkset links.

I originally wrote this with @jaymcgavren but had to recommit because
of really bad rebase clusterpoop. I hope you forgive me, Jay.

@olivierlacan olivierlacan force-pushed the olivierlacan:add-changelog-link branch to cf7d9b2 Feb 11, 2016

@olivierlacan

This comment has been minimized.

Copy link
Contributor

olivierlacan commented Feb 11, 2016

Rebased.

@indirect

This comment has been minimized.

Copy link
Member

indirect commented Feb 12, 2016

I am 👍 on this, reading a changelog link out of the gemspec metadata hash seems good to me.

@arthurnn

This comment has been minimized.

Copy link
Member

arthurnn commented Feb 28, 2016

I am also 👍 on this, however I would like us to finish #1127 first, before adding more links.

@homu

This comment has been minimized.

Copy link
Collaborator

homu commented Mar 8, 2016

☔️ The latest upstream changes (presumably #1209) made this pull request unmergeable. Please resolve the merge conflicts.

@dwradcliffe dwradcliffe added this to the Metadata milestone May 26, 2016

@kbrock

This comment has been minimized.

Copy link
Contributor

kbrock commented Jan 6, 2017

@olivierlacan #1234 merged - will look into the best way of getting this in.

Do you care if there is a field on a form? Or just reading from gemset.metadata[:changelog_uri] is good enough for you?

@olivierlacan

This comment has been minimized.

Copy link
Contributor

olivierlacan commented Jan 7, 2017

@indirect

This comment has been minimized.

Copy link
Member

indirect commented Jan 14, 2017

👍

olivierlacan added some commits Jan 26, 2017

Reorganize links to place changelog second
My justification for this is that the changelog link is more news-worthy perhaps. Feel free to discuss.

@olivierlacan olivierlacan force-pushed the olivierlacan:add-changelog-link branch from f248a03 to c849d1b Jan 26, 2017

@olivierlacan

This comment has been minimized.

Copy link
Contributor

olivierlacan commented Jan 26, 2017

Closing since we @kbrock made #1553 with no migration required.

@olivierlacan olivierlacan deleted the olivierlacan:add-changelog-link branch Jan 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment