Skip to content
Commits on May 3, 2016
  1. @homu

    Auto merge of #1583 - RochesterinNYC:update-bundled-ca-certificates-s…

    homu committed May 4, 2016
    …cript, r=segiddins
    
    Update `update_bundled_ca_certificates` utility script for directory nesting
    
    - Also updates the ssl certs with the minimum certs needed and nests them in directories named for the hosts they can authenticate against. The arrangement of the certs changed/occurred because the ssl certs in Rubygems were modeled after the ssl cert arrangement in Bundler. However, this arrangement was produced through manual testing and configured/arranged in bundler/bundler#4380 instead of programmatically. I'm unsure how I would go about writing or updating the `update_bundled_ca_certificates` script in a way that could reproduce this current manual arrangement. Hence, this PR includes a commit for rearranging of the ssl certs based off the programmatic utility script (instead of a manual process).
    - Related to discussion at #1555
    
    cc: @segiddins @indirect
  2. @RochesterinNYC
  3. @RochesterinNYC

    Update `update_bundled_ca_certificates` script to handle writing certs

    RochesterinNYC committed Apr 15, 2016
    into nested new directory structure
Commits on Apr 30, 2016
  1. @homu

    Auto merge of #1606 - rubygems:seg-molinillo-0.4.5, r=segiddins

    homu committed Apr 30, 2016
    Update vendored Molinillo to 0.4.5
    
    # Description:
    
    See https://github.com/CocoaPods/Molinillo/releases/0.4.5
    
    # Tasks:
    
    - [ ] Describe the problem / feature
    - [ ] Write tests
    - [ ] Write code to solve the problem
    - [ ] Get code review from coworkers / friends
    - [ ] [Squash commits](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)
    
    I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
  2. @segiddins
Commits on Apr 29, 2016
  1. @homu

    Auto merge of #1605 - djberg96:cert_check, r=segiddins

    homu committed Apr 29, 2016
    Raise an explicit error if Signer#sign is called with no certs
    
    # Description:
    
    This PR addresses an unfriendly error message that I brought up in #1413. It now explicitly raises an error if no certs are found. I also added a test for it.
    ______________
    
    I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
  2. @djberg96
Commits on Apr 27, 2016
  1. @segiddins
  2. @segiddins
Commits on Apr 26, 2016
  1. @homu

    Auto merge of #1600 - rubygems:seg-ui-require-gem-util, r=segiddins

    homu committed Apr 26, 2016
    [UserInteraction] Require gem/util since it is used by SilentUI
    
    # Description:
    
    Likely fixes an error with the bundler specs introduced by #1588.
  2. @segiddins
  3. @segiddins

    [Server] Remove XSS vulnerabilities

    segiddins committed Apr 25, 2016
    1) HTML escape user-supplied strings
    2) URL encode user-supplied URL substrings
Commits on Apr 25, 2016
  1. @homu

    Auto merge of #1598 - jasonkarns:patch-1, r=segiddins

    homu committed Apr 26, 2016
    Correct spelling of environment in Issue template
    
    # Description:
    
    Typo in Issues template
    
    # Tasks:
    
    I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
  2. @jasonkarns
  3. @djberg96

    Added #1418 and #1588 to History.

    djberg96 committed Apr 25, 2016
  4. @djberg96

    Merge pull request #1418 from nobu/feature/win-symlink

    djberg96 committed Apr 25, 2016
    Try symlink on Windows
  5. @djberg96

    Merge pull request #1588 from coldacid/master

    djberg96 committed Apr 25, 2016
    Survive EINVAL from File.open on Windows
  6. @coldacid

    Use `Gem::Util::NULL_DEVICE` instead of hardcoded null device names

    coldacid committed Apr 20, 2016
    No need to recover from EINVAL or ENOENT in this case as the constant
    should always return the correct name of the null device on every
    platform.
    
    We could use `File::Constants::NULL` but it didn't exist before Ruby
    1.9.3. The constant we use instead exists within this project and
    still has a proper value even for older versions of Ruby.
Commits on Apr 23, 2016
  1. @homu

    Auto merge of #1596 - RochesterinNYC:add-instructions-for-updating-ma…

    homu committed Apr 24, 2016
    …nifest, r=segiddins
    
    Add instruction to `CONTRIBUTING.rdoc` specifying when to update `Manifest.txt`
    
    - It was not evident from the `CONTRIBUTING.rdoc` guidelines that an update to the `Manifest.txt` file was required when I had previously submitted a PR that added and removed some files. This PR updates to `CONTRIBUTING.rdoc` guidelines to include this caveat.
  2. @nobu

    Fix tests

    nobu committed Apr 23, 2016
  3. @nobu

    Try symlink on Windows

    nobu committed Dec 19, 2015
    Try symlink regardless platform name.  Now File.symlink is
    implemented on Windows.
  4. @homu

    Auto merge of #1594 - nobu:suppress-warnings, r=segiddins

    homu committed Apr 23, 2016
    Suppress warnings
    
    Suppress warnings with `-w` option.
  5. @nobu

    Remove the class for test

    nobu committed Apr 23, 2016
    Remove the class for test before method definitions to suppress
    method redefinition warnings.
  6. @nobu

    Fix shadowing outer variable

    nobu committed Apr 23, 2016
Commits on Apr 22, 2016
  1. @homu

    Auto merge of #1590 - djberg96:appveyor, r=duckinator

    homu committed Apr 23, 2016
    Revamp appveyor.yml file.
    
    This is an update to the appveyor.yml file. A bit about the changes:
    
    * Only tests the master branch. I'm not sure why we care about other branches but I can add them if you feel it's necessary.
    * Uses Powershell in the "install" portion instead of cmd.exe. This makes it easier to skip gem installation if the dependencies we need are already installed. PS is just better in general.
    * Removes all that Travis stuff. I have no idea what that's about. This ain't Travis.
    * Caches the gem directories for each distribution. We don't need to re-provision gems every time we build, so this speeds up the build process.
    * No after-test task. No idea why we care about that.
    
    I tried it with local settings on my own fork and it worked fine. All the builds, including 1.9.3, were green.
  2. @djberg96

    Revamp appveyor.yml file.

    djberg96 committed with djberg96 Apr 22, 2016
    Added additional branches, set TRAVIS env variable.
Commits on Apr 20, 2016
  1. @RochesterinNYC
Commits on Apr 14, 2016
  1. @homu

    Auto merge of #1565 - punkle:redact_password, r=copiousfreetime

    homu committed Apr 15, 2016
    Redact uri password from error output when gem fetch fails
    
    # Description:
    Previously when a gem install from an authenticated source failed the error message showed the password in plain text. This change ensures that the message has the password redacted.
    ______________
    
    # Tasks:
    
    - [x] Describe the problem / feature
    - [x] Write tests
    - [x] Write code to solve the problem
    - [x] Get code review from coworkers / friends
    - [x] [Squash commits](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)
    
    I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
Commits on Apr 12, 2016
  1. @punkle

    Redact uri password from error output when gem fetch fails

    punkle committed with Brian Fletcher Mar 24, 2016
Commits on Apr 5, 2016
  1. @segiddins
  2. @segiddins
Commits on Apr 2, 2016
  1. @homu

    Auto merge of #1572 - duckinator:maintainers-md-to-txt, r=indirect

    homu committed Apr 3, 2016
    MAINTAINERS.md -> MAINTAINERS.txt
    
    # Description:
    
    Rename MAINTAINERS.md to MAINTAINERS.txt because it's not actually markdown.
    
    (See: https://github.com/rubygems/rubygems/blob/master/MAINTAINERS.md)
    
    # Tasks:
    
    - [x] Describe the problem / feature
    - [x] Solve the problem
    - [ ] Get code review from coworkers / friends
    
    I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
Commits on Mar 31, 2016
  1. @homu

    Auto merge of #1575 - unak:patch-1, r=segiddins

    homu committed Apr 1, 2016
    Version numbers may be two-digits.
    
    # Description:
    
    Version numbers may be two-digits.
    
    # Tasks:
    
    - [x] Describe the problem / feature
    - [x] Write tests
    - [ ] Write code to solve the problem
    - [ ] Get code review from coworkers / friends
    - [ ] [Squash commits](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)
    
    I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
  2. @unak
  3. @duckinator
Something went wrong with that request. Please try again.