Permalink
Commits on Jan 17, 2017
  1. Auto merge of #1691 - sdaubert:update_crypto, r=segiddins

    Update cryptography for Gem::Security
    
    # Description:
    
    Update cryptography for Gem::Security as proposed in #1688 :
    - replace SHA-1 digest by SHA-256 for signing with RSA algorithm,
    - update default RSA key length from 2048 to 3072 bits.
    
    ---
    # Tasks:
    - [X] Describe the problem / feature
    - [X] Write tests
    - [X] Write code to solve the problem
    - [ ] Get code review from coworkers / friends
    - [ ] [Squash commits](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)
    
    I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
    homu committed Jan 17, 2017
  2. test_build_signed_gem: use @current_dir instead of File.dirname(__FIL…

    …E__)
    sdaubert committed Jan 17, 2017
Commits on Jan 16, 2017
  1. Auto merge of #1819 - olleolleolle:patch-1, r=segiddins

    RakeBuilder: avoid frozen string issue
    
    # Description:
    
    This PR adds a missing `#dup` ("convert frozen string literal to a mutable String object instance") in the same way that 45966be did.
    
    The problem only appears when there're `args` to `.build`. To trigger this behavior, I duplicated a test and added a variable with a non-empty array of an empty string (to have benign test data).
    
    **What it looks like without the fix**
    
    Without this change, the user's failure will look like this:
    
    ```
    Gem::Ext::BuildError: ERROR: Failed to build gem native extension.
    can't modify frozen String, created at
    /home/travis/.rvm/rubies/jruby-9.1.7.0/lib/ruby/stdlib/rubygems/ext/rake_builder.rb:11
    ```
    
    **Reproduce**
    
    To reproduce the issue, write a `mkrf_conf.rb` which calls `build`. Here is an example `ext/mkrf_conf.rb` with a failing build: https://github.com/sickill/rainbow/blob/master/ext/mkrf_conf.rb
    
    # Tasks:
    
    - [x] Describe the problem / feature
    - [x] Write tests
    - [x] Write code to solve the problem
    - [x] Get code review from coworkers / friends
    
    I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
    homu committed Jan 16, 2017
  2. Auto merge of #1820 - segiddins:seg-bundler-ci-fix, r=segiddins

    Fix failing Bundler 1.8.7 CI builds
    
    # Description:
    
    ______________
    
    # Tasks:
    
    - [ ] Describe the problem / feature
    - [ ] Write tests
    - [ ] Write code to solve the problem
    - [ ] Get code review from coworkers / friends
    
    I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
    homu committed Jan 16, 2017
  3. [CI] Retry after running a command fails

    segiddins committed Jan 16, 2017
  4. Auto merge of #1812 - rubygems:seg-molinillo-0.5.5, r=segiddins

    Update vendored Molinillo to 0.5.5
    
    # Description:
    
    See https://github.com/CocoaPods/Molinillo/releases/0.5.5
    
    # Tasks:
    
    - [ ] Describe the problem / feature
    - [ ] Write tests
    - [ ] Write code to solve the problem
    - [ ] Get code review from coworkers / friends
    
    I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
    homu committed Jan 16, 2017
  5. RakeBuilder test: rename method

      - this avoids the reek warning Prima Donna Method; avoids confusing the reader
    olleolleolle committed Jan 16, 2017
  6. RakeBuilder test: Extract fixture file creation

    olleolleolle committed Jan 16, 2017
  7. RakeBuilder: test with non-empty args list given

    olleolleolle committed Jan 16, 2017
  8. RakeBuilder: avoid frozen string issue

      - See 45966be which had this fix most everywhere else
    olleolleolle committed on GitHub Jan 16, 2017
Commits on Jan 15, 2017
  1. Update Bundler to v1.14.0.pre.2

    segiddins committed Jan 15, 2017
Commits on Jan 7, 2017
  1. Update vendored Molinillo to 0.5.5

    segiddins committed Jan 7, 2017
Commits on Jan 2, 2017
  1. Auto merge of #1809 - norchard:master, r=segiddins

    Fixed broken links and overzealous URL encoding in gem server
    
    # Description:
    
    Bugs introduced in commit a58d893
    
    Fix for Issue #1793: Bad hrefs in 'gem server'- incorrect non-alpha character encoding
    
    1. Reintroduced erroneously deleted characters in links.
    
    2. Removed URL encoding from homepage links, which broke links. For example, "http://rubyonrails.org" became "http%3A%2F%2Frubyonrails.org". Added a method called uri_encode instead of using the deprecated URI.encode to encode unsafe characters without encoding the URL itself.
    
    3. Removed URL encoding from doc path. The doc_root function that generates doc path already encodes the gem name. The second encoding broke the link.
    ______________
    
    # Tasks:
    
    - [X] Describe the problem / feature
    - [X] Write tests
    - [X] Write code to solve the problem
    - [X] Get code review from coworkers / friends
    
    I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
    homu committed Jan 2, 2017
Commits on Dec 31, 2016
  1. Fixed broken links and overzealous URL encoding in gem server

    Bugs introduced in commit a58d893
    
    Fix for Issue #1793: Bad hrefs in 'gem server'- incorrect non-alpha character encoding
    
    1. Reintroduced erroneously deleted characters in links.
    
    2. Removed URL encoding from homepage links, which broke links. For example, "http://rubyonrails.org" became "http%3A%2F%2Frubyonrails.org". Added a method called uri_encode instead of using the deprecated URI.encode to encode unsafe characters without encoding the URL itself.
    
    3. Removed URL encoding from doc path. The doc_root function that generates doc path already encodes the gem name. The second encoding broke the link.
    norchard committed Dec 30, 2016
Commits on Dec 29, 2016
  1. Auto merge of #1808 - jeremyevans:mkmf_log, r=segiddins

    Don't output mkmf.log message if compilation didn't fail
    
    # Description:
    
    The presence of mkmf.log does not signal failure, the return code
    does.  Before this commit, if compilation succeeded but produced
    a mkmf.log, the output indicates that compilation failed, which is
    quite confusing.
    
    # Tasks:
    
    - [X] Describe the problem / feature
    - [X] Write tests
    - [X] Write code to solve the problem
    - [ ] Get code review from coworkers / friends
    
    I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
    homu committed Dec 29, 2016
  2. Add test for mkmf.log warning

    jeremyevans committed Dec 29, 2016
  3. Don't output mkmf.log message if compilation didn't fail

    The presense of mkmf.log does not signal failure, the return code
    does.  Before this commit, if compilation succeeded but produced
    a mkmf.log, the output indicates that compilation failed, which is
    quite confusing.
    jeremyevans committed Dec 29, 2016
Commits on Dec 26, 2016
  1. Auto merge of #1805 - rubygems:seg-test-on-2.4, r=indirect

    [Travis] Test on 2.4.0
    
    # Description:
    
    Yay larger test matrices!
    
    # Tasks:
    
    - [x] Describe the problem / feature
    - [x] Write tests
    - [x] Write code to solve the problem
    - [x] Get code review from coworkers / friends
    
    I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
    homu committed Dec 26, 2016
Commits on Dec 25, 2016
  1. [Travis] Tighten up matching for stable branches

    segiddins committed Dec 25, 2016
  2. [CI] Ensure only preferred rake version is installed

    segiddins committed Dec 25, 2016
  3. [Travis] Test on 2.4.0

    segiddins committed Dec 25, 2016
Commits on Dec 19, 2016
  1. Auto merge of #1796 - matk0:patch-1, r=indirect

    Update Code of Conduct to Contributor Covenant v1.4.0
    
    Solves #1503.
    
    Link to MAINTAINERS.txt included in the CoC.
    
    # Tasks:
    - [x] Describe the problem / feature
    - [x] Write tests (not needed)
    - [x] Write code to solve the problem (no code needed)
    - [x] Get code review from coworkers / friends
    - [x] [Squash commits] (only one commit)
    homu committed Dec 19, 2016
Commits on Dec 18, 2016
  1. Auto merge of #1801 - rubygems:seg-require-speed, r=indirect

    Improve -rubygems performance
    
    # Description:
    
    Makes `require "rubygems"` faster
    
    # Tasks:
    
    - [ ] Describe the problem / feature
    - [ ] Write tests
    - [ ] Write code to solve the problem
    - [ ] Get code review from coworkers / friends
    
    I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
    homu committed Dec 18, 2016
Commits on Dec 17, 2016
  1. [Source::Lock] Avoid hash collisions with un-wrapped sources

    segiddins committed Dec 12, 2016
  2. [Source] Autoload URI to speedup requiring rubygems

    URI takes a while to initialize, this makes `-rubygems` much faster when no sources are constructed
    segiddins committed Dec 12, 2016
Commits on Dec 11, 2016
  1. Update Code of Conduct to Contributor Covenant v1.4.0

    Link to MAINTAINERS.txt included.
    matk0 committed on GitHub Dec 11, 2016
Commits on Nov 30, 2016
  1. Auto merge of #1791 - pkuczynski:patch-1, r=segiddins

    Fixing links markdown formatting in README
    
    # Description:
    
    Some of the links had incorrect format and some others was done using html tags instead of markdown. I fixed both cases.
    ______________
    
    # Tasks:
    
    - [X] Describe the problem / feature
    - [ ] Write tests
    - [ ] Write code to solve the problem
    - [X] Get code review from coworkers / friends
    
    I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
    homu committed Nov 30, 2016
  2. Fix link for UPGRADING document

    pkuczynski committed on GitHub Nov 30, 2016
  3. Fixing links markdown formatting in README

    pkuczynski committed on GitHub Nov 30, 2016
Commits on Nov 28, 2016
  1. Auto merge of #1788 - nobu:special_const-dup, r=segiddins

    No TypeError on dup
    
    # Description:
    
    Special constants (`Integer`, `Symbol`, `true`, `false`, `nil`, etc) no longer raises a `TypeError` at `dup` since 2.4.
    https://bugs.ruby-lang.org/issues/12979
    ______________
    
    # Tasks:
    
    - [x] Describe the problem / feature
    - [x] Write tests
    - [x] Write code to solve the problem
    - [ ] Get code review from coworkers / friends
    
    I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
    homu committed Nov 28, 2016