Gem is installed incomplete when RDoc fails.

[voxik]

Hello,

The commit [1] changes behavior of rubygems due to issue [2]. However, it results in installed gem without installed documentation. I consider this behavior broken. There are 3 possible solutions:

1. Work in transaction and revert all changes done during installation prior the error.
2. Keep working as previously, i.e. ignore the RDoc bug and continue the installation.
3. Add commandline switch which can control the behavior, e.g. ignore errors.

You can compare the functionality using Ruby 1.8.7 with bundled rdoc, which has difficulties to pares documentation of builder 2.1.2. Rubygems 1.3.7 'successfully' (i.e. return code 0) installed the gem while newer Rubygems fails, while the gem is installed anyway (return code 1).

[1] f379d5b
[2] http://rubyforge.org/tracker/index.php?func=detail&aid=28935&group_id=126&atid=575

[drbrain]

We discussed the previous behavior and now consider it broken. Now RubyGems tells you if anything went wrong during the install process so you can double-check it.

If you're performing automated installation and are worried about unsuccessful installs meaning non-working gems you should use --no-rdoc --no-ri.

If you still need documentation you can use gem rdoc --all which will add missing documentation (--no-overwrite is the default).

[voxik]

I have discovered this issue when trying to figure out what was causing build failure of Fedora builder package [1]. As you can see from the log [2], there is clearly stated:

Successfully installed builder-2.1.2
1 gem installed

so I am wondering why, at least, the message does not corresponds to the return code.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=716048
[2] https://bugzilla.redhat.com/attachment.cgi?id=508590