New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gem command should notify the user when it is out of date #1620

Open
swrobel opened this Issue May 20, 2016 · 7 comments

Comments

Projects
None yet
5 participants
@swrobel

swrobel commented May 20, 2016

I'm would like to suggest a feature.

This issue is related to:
The command line gem

I noticed that pip provides feedback as follows when it is out of date:

You are using pip version 7.1.2, however version 8.1.2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.

Similar behavior from rubygems would likely encourage many more users to update their client. I use ruby on a daily basis and often forget to run gem update --system for long periods of time.

I will abide by the code of conduct.

@segiddins

This comment has been minimized.

Show comment
Hide comment
@segiddins

segiddins May 21, 2016

Member

I'm 👎 on this -- I really don't like when command line tools print more than they need to

Member

segiddins commented May 21, 2016

I'm 👎 on this -- I really don't like when command line tools print more than they need to

@duckinator

This comment has been minimized.

Show comment
Hide comment
@duckinator

duckinator May 29, 2016

Member

~~~I'm also 👎 on this. It would either make a network request every time you run the gem executable, or it would add a significant amount of code complexity to avoid doing so.~~

(EDIT: I was wrong.)

Member

duckinator commented May 29, 2016

~~~I'm also 👎 on this. It would either make a network request every time you run the gem executable, or it would add a significant amount of code complexity to avoid doing so.~~

(EDIT: I was wrong.)

@swrobel

This comment has been minimized.

Show comment
Hide comment
@swrobel

swrobel May 29, 2016

Not really, I think you're overthinking it. Just include the latest rubygems version with every payload from the server.

swrobel commented May 29, 2016

Not really, I think you're overthinking it. Just include the latest rubygems version with every payload from the server.

@duckinator

This comment has been minimized.

Show comment
Hide comment
@duckinator

duckinator Jun 1, 2016

Member

Fair enough! So, if that were to be a thing, a prerequisite would be rubygems.org including the latest rubygems version in every API response.

It would also need to have that version number printed only when appropriate. I can't even grok how the RubyGems executable handles I/O, so I'll yield to other people on how difficult that actually is. (lib/rubygems/user_interaction.rb seems to be a big part of it, but I can't figure out how exactly it all goes together.)

Member

duckinator commented Jun 1, 2016

Fair enough! So, if that were to be a thing, a prerequisite would be rubygems.org including the latest rubygems version in every API response.

It would also need to have that version number printed only when appropriate. I can't even grok how the RubyGems executable handles I/O, so I'll yield to other people on how difficult that actually is. (lib/rubygems/user_interaction.rb seems to be a big part of it, but I can't figure out how exactly it all goes together.)

@swrobel

This comment has been minimized.

Show comment
Hide comment
@swrobel

swrobel Sep 6, 2017

This seems more relevant in light of the recent vulnerabilities, and considering the Bundler implemented this feature

Edit: just noticed who implemented the feature in Bundler. Perhaps he'll pipe up here again 😉

swrobel commented Sep 6, 2017

This seems more relevant in light of the recent vulnerabilities, and considering the Bundler implemented this feature

Edit: just noticed who implemented the feature in Bundler. Perhaps he'll pipe up here again 😉

@duckinator

This comment has been minimized.

Show comment
Hide comment
@duckinator

duckinator Sep 7, 2017

Member

thanks for the nudge, @swrobel! I've got a bit too much on my plate right now to take it up myself, but I brought it up on Slack and hopefully someone else can at least figure out a plan for it.

Member

duckinator commented Sep 7, 2017

thanks for the nudge, @swrobel! I've got a bit too much on my plate right now to take it up myself, but I brought it up on Slack and hopefully someone else can at least figure out a plan for it.

@segiddins

This comment has been minimized.

Show comment
Hide comment
@segiddins

segiddins Sep 7, 2017

Member

@swrobel I see what you did there ;)

I've got my hands quite full at the moment, and as I've said elsewhere, I personally consider this a "nice to have" rather than a necessity, but it might happen some day. Hopefully someone else beats me to it

Member

segiddins commented Sep 7, 2017

@swrobel I see what you did there ;)

I've got my hands quite full at the moment, and as I've said elsewhere, I personally consider this a "nice to have" rather than a necessity, but it might happen some day. Hopefully someone else beats me to it

@bronzdoc bronzdoc self-assigned this Jul 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment