Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates needed to util/ci (Travis)? #2368

Closed
1 of 5 tasks
MSP-Greg opened this issue Jul 26, 2018 · 9 comments
Closed
1 of 5 tasks

Updates needed to util/ci (Travis)? #2368

MSP-Greg opened this issue Jul 26, 2018 · 9 comments

Comments

@MSP-Greg
Copy link
Contributor

Just checking test setup on Appveyor & Travis. Should any of the following be updated, re minitest (v?), bundler (1.16.3), & Robocop (0.58.2)?

rubygems/util/ci

Lines 52 to 60 in 7bbd0de

if (RUBY_VERSION >= "2.2.0" && RUBY_VERSION < "2.3.0") || RUBY_VERSION >= "2.6.0"
run('gem', %w(install minitest -v 5.4.3))
end
# 2.5 images of Travis was broken about bundler installation.
if RUBY_VERSION >= "2.5.0" && RUBY_VERSION < "2.6.0"
run('gem', %w(install bundler -v 1.16.2))
end
run('gem', %w(install rubocop -v 0.58.1))

This issue is related to:

  • Network problems
  • Installing a library
  • Publishing a library
  • The command line gem
  • Other

Here are my current environment details:

$ gem env version
NA

I will abide by the code of conduct.

@segiddins
Copy link
Member

They could be, there just pinned to make sure there's no unexpected breakage

@MSP-Greg
Copy link
Contributor Author

@segiddins

I should have been clearer. Since f1eb3b8, there isn't a need to use older version of mintest.

Re minitest, RG's CI is mostly using whatever Appveyor and Travis have installed.

Maybe the question should have been - should Travis & Appveyor CI scripts be updated so both are using the same (and newer) versions of needed gems?

I'm biased towards latest/greatest; I don't know what others think...

@segiddins
Copy link
Member

Maybe the question should have been - should Travis & Appveyor CI scripts be updated so both are using the same (and newer) versions of needed gems?

ah in that case, sure!

@segiddins segiddins reopened this Jul 31, 2018
@MSP-Greg
Copy link
Contributor Author

I'll run tests on my fork with Appveyor & Travis. Not tonite.

@duckinator
Copy link
Member

Would doing what rake setup does and having it install the dependencies from rubygems-update.gemspec work?

rubygems/Rakefile

Lines 13 to 20 in 8ceb7ca

desc "Setup Rubygems dev environment"
task :setup => ["bundler:checkout"] do
gemspec = Gem::Specification.load(File.expand_path("../rubygems-update.gemspec", __FILE__))
gemspec.dependencies.each do |dep|
sh "gem install '#{dep.name}:#{dep.requirement.to_s}'"
end
end

@segiddins
Copy link
Member

I think it should!

@duckinator
Copy link
Member

@segiddins in that case: should it call rake setup directly, or does rake setup relying on rake bundler:checkout make it not usable as-is? (that's an easily-adjusted thing, i just don't know whether or not it's a problem.)

@segiddins
Copy link
Member

Should be fine to call it directly, give it a try? If it doesn’t work, we can figure something out

@MSP-Greg
Copy link
Contributor Author

MSP-Greg commented Nov 1, 2018

Reviewing this, there are some issues with the Travis builds, related to bundler & (missing) bundled gems...

I'll try to keep an eye on whether Travis improves the situation, as I've opened issues there. Then there's the issue of whether to test with released or updated dependencies...

Closing...

@MSP-Greg MSP-Greg closed this as completed Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants