1.8.23 actually does not install pem file #320

Closed
mtasaka opened this Issue Apr 23, 2012 · 4 comments

Comments

Projects
None yet
3 participants
@mtasaka

mtasaka commented Apr 23, 2012

1.8.23 is the security fix release to verify ssl connection and it seems that for
this purpose lib/rubygems/ssl_certs/ca-bundle.pem file is bundled in
rubygems 1.8.23 tarball. However rake install does not actually install this
file. Unless I am mistaken, this means that the fix on 1.8.23 tarball is incomplete?

@mtasaka

This comment has been minimized.

Show comment
Hide comment
@mtasaka

mtasaka Apr 23, 2012

Proposal patch

--- rubygems-1.8.23/lib/rubygems/commands/setup_command.rb.debug    2012-04-23 12:48:25.956730621 +0900
+++ rubygems-1.8.23/lib/rubygems/commands/setup_command.rb  2012-04-23 15:52:39.867694397 +0900
@@ -210,6 +210,8 @@
 
     Dir.chdir 'lib' do
       lib_files = Dir[File.join('**', '*rb')]
+      pem_files = Dir[File.join('**', '*pem')]
+      lib_files.concat(pem_files)
 
       lib_files.each do |lib_file|
         dest_file = File.join lib_dir, lib_file

mtasaka commented Apr 23, 2012

Proposal patch

--- rubygems-1.8.23/lib/rubygems/commands/setup_command.rb.debug    2012-04-23 12:48:25.956730621 +0900
+++ rubygems-1.8.23/lib/rubygems/commands/setup_command.rb  2012-04-23 15:52:39.867694397 +0900
@@ -210,6 +210,8 @@
 
     Dir.chdir 'lib' do
       lib_files = Dir[File.join('**', '*rb')]
+      pem_files = Dir[File.join('**', '*pem')]
+      lib_files.concat(pem_files)
 
       lib_files.each do |lib_file|
         dest_file = File.join lib_dir, lib_file
@mtasaka

This comment has been minimized.

Show comment
Hide comment
@mtasaka

mtasaka Apr 23, 2012

Note that released ruby 1.9.3 patchlevel 194 installs pem files (perhaps
because ruby tarball does not use this method).

mtasaka commented Apr 23, 2012

Note that released ruby 1.9.3 patchlevel 194 installs pem files (perhaps
because ruby tarball does not use this method).

@mtasaka

This comment has been minimized.

Show comment
Hide comment
@mtasaka

mtasaka Apr 24, 2012

Well, actually this is not "rake install", but actually "ruby setup.rb" (setup.rb is in rubygems 1.8.23 tarball) does not install .pem file.

mtasaka commented Apr 24, 2012

Well, actually this is not "rake install", but actually "ruby setup.rb" (setup.rb is in rubygems 1.8.23 tarball) does not install .pem file.

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Apr 27, 2012

Contributor

Confirmed also on JRuby...caused us a little pain trying to figure out why gems wouldn't push after upgrading.

Contributor

headius commented Apr 27, 2012

Confirmed also on JRuby...caused us a little pain trying to figure out why gems wouldn't push after upgrading.

@evanphx evanphx closed this in 521163b Apr 27, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment