Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise an explicit error if Signer#sign is called with no certs #1605

Merged
merged 1 commit into from Apr 29, 2016

Conversation

djberg96
Copy link
Contributor

@djberg96 djberg96 commented Apr 29, 2016

Description:

This PR addresses an unfriendly error message that I brought up in #1413. It now explicitly raises an error if no certs are found. I also added a test for it.

Closes #1413.


I will abide by the code of conduct.

@segiddins
Copy link
Member

@homu r+

@homu
Copy link
Contributor

homu commented Apr 29, 2016

📌 Commit fff6e78 has been approved by segiddins

@homu
Copy link
Contributor

homu commented Apr 29, 2016

⚡ Test exempted - status

@homu homu merged commit fff6e78 into rubygems:master Apr 29, 2016
homu added a commit that referenced this pull request Apr 29, 2016
Raise an explicit error if Signer#sign is called with no certs

# Description:

This PR addresses an unfriendly error message that I brought up in #1413. It now explicitly raises an error if no certs are found. I also added a test for it.
______________

I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
@djberg96
Copy link
Contributor Author

@segiddins Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants