Join GitHub today
Progress Bar During Downloads #2
I like it, however I'm not sure of including ProgressBar globally.
Saying this because there is a progressbar gem: https://rubygems.org/gems/progressbar and it might clash.
Rubinius guys did a simple implementation:
That did not depend on the the additional class.
We also need to check how this could affect the automated output, specially for projects like Bundler and such.
I think the good idea will be remove ProgressBar at all.
Also, all the remote operations are been handled by this, so fetching of specs and everything is streamed.
There is also another problem, it doesn't work with 1.8.7:
See my patch to only generate the progress report when a gem is being downloaded: http://gist.github.com/600349
Thank you Ryan
Posted about this to rubygems-devel:
Waiting for feedback there before decide to integrate it.
I bring this topic to RubyGems about making the progress bar something part of UI component to have better control of it.
Also, this print/flush approach do not work nice with remote automations like Chef, so move of this to the UI and have an option to turn it of will be the best.
See my thread and further comments there:
This should be integrated, but to my bad, I'm not 100 percent sure on the approach and to my bad haven't received the feedback from other RubyGems maintainers
Will keep you posted.
I'm working today on extend UserInteraction to support a configurable Download reporter, in that way, it will make more easy for non-tty interfaces to work and not generate a bunch of output.
Thank you again for your contribution. Will post a link to the commits once I'm done for you to test and review.
I've posted this to the list for review:
I've implemented Ryan idea into a more modular and non-tty friendly version under download-reporter branch:
Let me know your thoughts guys.