support SOURCE_DATE_EPOCH to make gem tar reproducible #2289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Files compared using freshly created gem's and 10seconds sleep inbetween |
Optionally respect the SOURCE_DATE_EPOCH environment variable to be used instead of Time.now to allow reproducible builds of created gem tarballs. In case none is specified, fall back to the current time.
|
@bundlerbot r+ |
|
|
bundlerbot
added a commit
that referenced
this pull request
May 14, 2018
…hsbt support SOURCE_DATE_EPOCH to make gem tar reproducible Optionally respect the SOURCE_DATE_EPOCH environment variable to be used instead of Time.now to allow reproducible builds of created gem tarballs. In case none is specified, fall back to the current time. # Description: The problem is that using Time.now will change during time which makes created gem tarballs not reproducible (bit by bit identical). This is related to making the .gemspec file's itself reproducible: #2278 Spec: https://reproducible-builds.org/specs/source-date-epoch/ Buy-in: https://reproducible-builds.org/docs/buy-in/ ______________ # Tasks: - [x] Describe the problem / feature - [x] Write tests - [x] Write code to solve the problem - [x] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
|
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Optionally respect the SOURCE_DATE_EPOCH environment variable to be used
instead of Time.now to allow reproducible builds of created gem tarballs.
In case none is specified, fall back to the current time.
Description:
The problem is that using Time.now will change during time which makes created gem tarballs not reproducible (bit by bit identical).
This is related to making the .gemspec file's itself reproducible: #2278
Spec:
https://reproducible-builds.org/specs/source-date-epoch/
Buy-in:
https://reproducible-builds.org/docs/buy-in/
Tasks:
I will abide by the code of conduct.