Added a builder for CMakeLists.txt #265

Merged
merged 15 commits into from Dec 10, 2012

Projects

None yet

6 participants

@aespinosa
Contributor

Hi,

I added CMakeLists.txt to the list of extension builders. I made it similar to the configure builder that passes the prefix in -DCMAKE_INSTALL_PREFIX

@luislavena luislavena was assigned Jan 20, 2012
@luislavena
Member

Awesome, thank you!

Can you add a test that ensures this builder is called?

@evanphx
Member
evanphx commented Mar 12, 2012

As soon as a test for this shows up, I'll merge it!

@evanphx
Member
evanphx commented Oct 6, 2012

Since the test hasn't shown up, please reopen when you get it sorted. Thanks!

@evanphx evanphx closed this Oct 6, 2012
havenwood and others added some commits Dec 1, 2012
@havenwood havenwood When dependencies will not be met with uninstall, have [yN] be the de…
…fault instead of [Yn].
9b00fc9
@kou kou Ignore default gems in cleanup d197a57
@drbrain drbrain Regenerated test certificates for FIPS mode
Previously the test certificates had (broken) 512 bit keys which are too
short for FIPS mode.  The new keys have 2048 bit keys which should last
a good while.  Fixes #365

Updated History.txt for commits since 2.0.0.preview2
b3d629f
@drbrain drbrain Merge pull request #412 from srawlins/master
Allow DependencyInstaller.new to receive :build_args
9ce6428
@drbrain drbrain Merge pull request #409 from kou/ignore-default-gems-in-cleanup
Ignore default gems in cleanup
c068379
@drbrain drbrain Display skipped default gems with -v
The list of skipped gems is too large to display every cleanup, but is
useful information.  Now it shows when you gem cleanup -v.

See also #409
764207d
@drbrain drbrain Updated History for #409 and #412 d9ec9e4
@drbrain drbrain Fixed listing remote gems
Gem::SpecFetcher#detect yields NameTuples instead of arrays.  This
caused none of the names to match the user's selection.

Fixes #410
20e15ee
@drbrain drbrain Ignore non-files when looking for local gems
RubyGems would try to install any filesystem entry, even if it wasn't a
file.  Now we ignore non-files.
4c85c7b
@drbrain drbrain Merge pull request #406 from Havenwood/master
When gem uninstall would break dependencies don't default to uninstall
3072c14
@drbrain drbrain Added test for #406 05c76a2
@drbrain drbrain Updated history for #406 746658d
@aespinosa
Contributor

Hello Evan, Luis,

Sorry it took a while to write the tests. Shall I make a new request for that?

@drbrain
Member
drbrain commented Dec 8, 2012

If you commit it to your cmake branch and push it will show up here.

@drbrain drbrain reopened this Dec 8, 2012
@drbrain
Member
drbrain commented Dec 8, 2012

Also, rebasing your commit on master will help us merge it.

@aespinosa aespinosa closed this Dec 8, 2012
@aespinosa
Contributor

Thanks for reopening the request Eric.

My rebase closed the ticket as I had to delete my remote branch first before pushing the rebased tree.

@aespinosa aespinosa reopened this Dec 8, 2012
@drbrain drbrain merged commit adf8843 into rubygems:master Dec 10, 2012

1 check passed

default The Travis build passed
Details
@drbrain
Member
drbrain commented Dec 10, 2012

I skipped the cmake tests if cmake does not succeed.

@drbrain drbrain added a commit that referenced this pull request Dec 10, 2012
@drbrain drbrain Updated History.txt for #265 71e15c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment