Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Don't define Date as an empty class: fix ruby-core #6702 #351

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

This pull request passes (merged 14a910c into 62653cb).

Contributor

zenspider commented Jul 5, 2012

We're going to have to reject this. Some gems used Date back in the day. We switched to Time and got a 30% speed boost out of it, but since some specs out there still have Date, applying this patch would raise exceptions whenever they were loaded.

@zenspider zenspider closed this Jul 5, 2012

I don't understand. How an empty Date class would be useful for those gems?

Owner

drbrain commented Jul 5, 2012

I switched to require 'date' in @f65ea70 as I no longer see a reason to avoid loading Date for real.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment