Fix incremental index updates (#232) #364

Merged
merged 2 commits into from Nov 27, 2012

Conversation

Projects
None yet
5 participants
Contributor

jfoy commented Aug 24, 2012

Initialize Gem::Specification in the same way when incrementally
updating indexes as in a full reindex.

#232

Fix incremental index updates
Initialize Gem::Specification in the same way when incrementally
updating indexes as in a full reindex.

Fixes #232

This pull request passes (merged 6bb445f into a1827da).

Add test case demonstrating update_index failure
Extend test_gem_indexer to better reflect system state in update_index.

This pull request passes (merged c848416 into a1827da).

Member

luislavena commented Aug 26, 2012

@drbrain @evanphx can you take a look to this?

Thank you.

Owner

evanphx commented Oct 6, 2012

There doesn't appear to be a new test, so how do we know the code fixes a bug?

Contributor

jfoy commented Oct 6, 2012

The existing test_update_index method in test_gem_indexer.rb doesn't correctly simulate the environment of an actual index update. In this pull I amended the test to demonstrate the problem, observed the failure, and added a change to make the test pass.

Should I add a new test instead of correcting the existing one?

drbrain added a commit that referenced this pull request Nov 27, 2012

@drbrain drbrain merged commit e166e43 into rubygems:1.8 Nov 27, 2012

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment