Fixes for empty ruby version #455

Merged
merged 2 commits into from Apr 4, 2013

Conversation

Projects
None yet
2 participants
@voxik
Contributor

voxik commented Feb 14, 2013

This prevents issues, when ruby configuration specifies --with-ruby-version=''. These are several small nits needed to fix http://bugs.ruby-lang.org/issues/7807

voxik added some commits Feb 14, 2013

Use File.join instead of manual path creation.
This prevents issues, when File.join in #new_default_spec removes
superfluous slashes while they are kept in expected paths. E.g. the test
would fail if ruby configuration specifies --with-ruby-version=''.

drbrain added a commit that referenced this pull request Apr 4, 2013

Merge pull request #455 from voxik/fixes-for-empty-ruby-version
Fixes for configure --with-ruby-version=''

@drbrain drbrain merged commit 74c5993 into rubygems:master Apr 4, 2013

1 check passed

default The Travis build passed
Details

drbrain added a commit that referenced this pull request Apr 4, 2013

drbrain added a commit that referenced this pull request Apr 4, 2013

drbrain added a commit that referenced this pull request Apr 4, 2013

Merge branch 'pietro-key_passphrase'
* pietro-key_passphrase: (154 commits)
  Update missed tests for rebase of #447
  Fixed pull request number type for #461
  Improve documentation of DependencyInstaller
  Alphabetize Gem::DependencyInstaller
  Removed commented out DependencyInstaller code
  Alter #489 to use GEM_SPEC_CACHE
  fix tests when GEM_SPEC is set in environment
  add support for ENV GEM_SPEC, fix #430
  Updated history for #443
  Don't alter Gem::Specification.dirs during install
  Default to Gem.dir as late as possible.
  Updated history for #455
  Update history for #456
  Update history for #462
  Add tests and alter output of #514
  add PATH to gem env
  Update History for #514
  Restore backwards-compatibility for #517
  Alphabetize RequestSet
  Undent RequestSet
  ...

Conflicts:
	test/rubygems/test_gem_commands_cert_command.rb
	test/rubygems/test_gem_package.rb

drbrain added a commit that referenced this pull request Jun 27, 2013

drbrain added a commit that referenced this pull request Jun 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment