Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeprecate bundle show #4586

Merged

Conversation

NeimadTL
Copy link
Contributor

@NeimadTL NeimadTL commented May 8, 2021

The timeline of how show got deprecated is on this issue's comment: #3243 (comment). We eventually decided to undeprecate show as no apparent reason was give
to deprecate it.

What was the end-user or developer problem that led to this PR?

bundle show was deprecated for no apparent reason.
timeline (see here)

What is your fix for the problem, implemented in this PR?

bundle show has been undeprecated.

Closes #3243.

Make sure the following tasks are checked

@welcome
Copy link

@welcome welcome bot commented May 8, 2021

Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack.

For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide

simi
simi approved these changes May 8, 2021
Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

@NeimadTL Thanks for not forgetting about this ❤️

Made one comment, but other than that it seems all good!

bundler/lib/bundler/cli.rb Show resolved Hide resolved
bundler/lib/bundler/cli.rb Outdated Show resolved Hide resolved
@NeimadTL
Copy link
Contributor Author

@NeimadTL NeimadTL commented May 9, 2021

@deivid-rodriguez , just made the recommended changes. Thanks again for all the information ;)

Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

One final round of comments, but seems mostly ready!

bundler/spec/other/major_deprecation_spec.rb Show resolved Hide resolved
bundler/spec/other/major_deprecation_spec.rb Show resolved Hide resolved
bundler/spec/other/major_deprecation_spec.rb Show resolved Hide resolved
bundler/spec/other/major_deprecation_spec.rb Show resolved Hide resolved
bundler/spec/other/major_deprecation_spec.rb Outdated Show resolved Hide resolved
@NeimadTL
Copy link
Contributor Author

@NeimadTL NeimadTL commented May 10, 2021

@deivid-rodriguez , hopefully good this time around. Thanks for your feedback

Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

Sorry I keep noticing more things we should delete 😅.

bundler/spec/other/major_deprecation_spec.rb Show resolved Hide resolved
bundler/spec/other/major_deprecation_spec.rb Outdated Show resolved Hide resolved
The timeline of how `show` got deprecated is on this issue's comment:
rubygems#3243 (comment).
We eventually decided to undeprecate `show` as no apparent reason was found
to deprecate it.
@deivid-rodriguez deivid-rodriguez force-pushed the enhancement/undeprecate_bundle_show branch from ca40176 to dad016c Compare May 12, 2021
@deivid-rodriguez
Copy link
Member

@deivid-rodriguez deivid-rodriguez commented May 12, 2021

Everything was addressed but there was one leftover issue where you had unintentionally committed a bundler/.rake_tasks~ file to the repository. I fixed that for you and rebased and squashed the PR since I was at it. Will merge after CI.

Thanks so much @NeimadTL for your contribution! ❤️

@deivid-rodriguez deivid-rodriguez enabled auto-merge May 12, 2021
@NeimadTL
Copy link
Contributor Author

@NeimadTL NeimadTL commented May 12, 2021

@deivid-rodriguez , thanks for fixing the leftover for me and thanks for help overall 🥇

@deivid-rodriguez deivid-rodriguez merged commit 1c70b05 into rubygems:master May 12, 2021
72 checks passed
deivid-rodriguez added a commit that referenced this issue May 25, 2021
…_show

Undeprecate bundle show

(cherry picked from commit 1c70b05)
deivid-rodriguez added a commit that referenced this issue May 25, 2021
…_show

Undeprecate bundle show

(cherry picked from commit 1c70b05)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants