Fix #461: Add --host option to owner command #462

Merged
merged 1 commit into from Apr 4, 2013

Conversation

Projects
None yet
2 participants
Contributor

hltbra commented Feb 23, 2013

@drbrain helped me with this pull request over #rubygems @ freenode.

I see other commands don't have --host also. Maybe it is time to create another method in Gem::GemcutterUtilities, similar to add_key_option and some test mixins.

Maybe a new rubygems/guides build should be deployed after this changeset.

Owner

drbrain commented Feb 23, 2013

I figured out @host is picked up automatically as Gem::GemcutterUtilities is included, this was my confusion in IRC.

It looks good, I will merge it after the RubyGems 2.0.0 release (should be next week).

@drbrain drbrain added a commit that referenced this pull request Apr 4, 2013

@drbrain drbrain Merge pull request #462 from hltbra/master
Fix #461: Add --host option to owner command
dbd860b

@drbrain drbrain merged commit dbd860b into rubygems:master Apr 4, 2013

1 check passed

default The Travis build passed
Details

@drbrain drbrain added a commit that referenced this pull request Apr 4, 2013

@drbrain drbrain Update history for #462 cc7bca4

@drbrain drbrain added a commit that referenced this pull request Apr 4, 2013

@drbrain drbrain Update history for #462 c6f65f7

@drbrain drbrain added a commit that referenced this pull request Apr 4, 2013

@drbrain drbrain Merge branch 'pietro-key_passphrase'
* pietro-key_passphrase: (154 commits)
  Update missed tests for rebase of #447
  Fixed pull request number type for #461
  Improve documentation of DependencyInstaller
  Alphabetize Gem::DependencyInstaller
  Removed commented out DependencyInstaller code
  Alter #489 to use GEM_SPEC_CACHE
  fix tests when GEM_SPEC is set in environment
  add support for ENV GEM_SPEC, fix #430
  Updated history for #443
  Don't alter Gem::Specification.dirs during install
  Default to Gem.dir as late as possible.
  Updated history for #455
  Update history for #456
  Update history for #462
  Add tests and alter output of #514
  add PATH to gem env
  Update History for #514
  Restore backwards-compatibility for #517
  Alphabetize RequestSet
  Undent RequestSet
  ...

Conflicts:
	test/rubygems/test_gem_commands_cert_command.rb
	test/rubygems/test_gem_package.rb
03f371e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment