Support non gnu libc linux platforms #5852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The symmetry with the "for command line" case is made more apparent.
On past versions there were observed cases of inconsistencies when some platforms were re-parsed. Ensure that a platform's string representation parses again in a platform object equal to the original.
Attempting to install a gem published as both *-linux and *-linux-musl results in the incorrect gem being picked up, causing build failures due to binary incompatibility. This is caused by the `nil` wildcard swallowing the libc information upon version comparison. Handle the linux case by performing only non-wildcard equality on the version and asserting 'gnu' and nil equivalence, while preserving the current behaviour for other OSes. Co-authored-by: Loic Nageleisen <loic.nageleisen@gmail.com>
deivid-rodriguez
added
rubygems: bug fix
rubygems: enhancement
and removed
rubygems: bug fix
labels
5 tasks
|
Let's do this! |
This was referenced Aug 22, 2022
deivid-rodriguez
changed the title
gem install support non gnu libc linux
This was referenced Aug 23, 2022
|
Thank you David! |
deivid-rodriguez
added a commit
that referenced
this pull request
Aug 24, 2022
Make `gem install` support non gnu libc linux (cherry picked from commit 9dc737d)
|
A tip for those who are publishing linux-gnu or linux-musl specific gems: make sure you add rubygems < 3.3.22 have the following problems:
|
4 tasks
maxlazio
pushed a commit
to gitlabhq/omnibus-gitlab
that referenced
this pull request
Apr 26, 2023
In https://gitlab.com/gitlab-org/omnibus-gitlab/-/merge_requests/6242, we dropped support for updating RubyGems in favor of using the version shipped by Ruby. However, that version may be outdated. For example, Ruby 3.0.5 ships with RubyGems v3.2.33, but for native gems that ship with precompiled musl extensions, we need to make sure we use RubyGems >= 3.3.22 (rubygems/rubygems#5852). This is to ensure Omnibus GitLab does not install the wrong native extension. Relates to https://gitlab.com/gitlab-org/gitlab/-/issues/408338 Changelog: changed
This was referenced Jul 14, 2023
ivoanjo
added a commit
to DataDog/libdatadog
that referenced
this pull request
Mar 4, 2024
…ch64-linux-gnu **What does this PR do?** This PR fixes platform detection not working correctly when the user's platform is `x86_64-linux-gnu`/`aarch64-linux-gnu`. This manifested to a user as the following error: > Profiling was requested but is not supported, profiling disabled: Your > ddtrace installation is missing support for the Continuous Profiler > because the `libdatadog` gem installed on your system is missing > binaries for your platform variant. > (Your platform: `x86_64-linux-gnu`) > (Available binaries: `x86_64-linux`, `x86_64-linux-musl`) In the past, rubygems did this normalization for us (we even had a comment mentioning it in the code!) but this was removed in rubygems/rubygems#5852 for Rubygems 3.4+ I'm also bumping the `GEM_MAJOR_VERSION` in the `version.rb` file so I can release this fix as libdatadog 6.0.0.2.0 for Ruby as soon as this PR is merged. **Motivation:** Make sure our platform detection code is correct. **Additional Notes:** N/A **How to test the change?** This change includes test coverage.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
gem installmay end up installing musl-specific variants on non musl platforms.What is your fix for the problem, implemented in this PR?
Make platform comparison and initialization support must and other non gnu lib linux.
NOTE: This is extracted from #4488, but focusing on the RubyGems side. #4488 will deal with adapting the Bundler side to cherry-pick the proper changes, so that
bundle installworks consistently across the different RubyGems versions.Fixes #3174.
Make sure the following tasks are checked