Remove useless directory parameter from builders .build methods. #669

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@voxik
Contributor
voxik commented Oct 4, 2013

This parameter was introduced 8 years ago (5834d27), but was never used. Although it might break some RubyGems plugin, it doesn't seems there exist any alternative RubyGems builder in the wild.

@voxik voxik Remove useless directory parameter from builders .build methods.
This parameter was introduced 8 years ago, but was never used. Although
it might break some RubyGems plugin, it doesn't seems there exist any
alternative RubyGems builder in the wild.
8aff174
@drbrain
Member
drbrain commented Oct 8, 2013

Since this change breaks API, even if it is probably unused, I must defer it until RubyGems 3.x ☹

@krainboltgreene
Member

This has been rebased, feel free to continue the PR there or we'll take care of it. (You still get all commit credit, obs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment