New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add country field in profiles table #396 #469
Merged
Merged
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
40fe149
add the field country
n3k00n3 23bdd30
using another gem
n3k00n3 756670a
almost there...
n3k00n3 cafe90e
removing unnecessary files
n3k00n3 67b688f
adding country column to be tested
n3k00n3 f1f7822
fixing profile_test
n3k00n3 63c5d16
add country: to de.yml
n3k00n3 9b5e991
adding a country filed to search
n3k00n3 7f88be8
country field
n3k00n3 ae63f5c
rspec solved
n3k00n3 6022635
Meine to Mein
n3k00n3 1484876
add condition to country field
n3k00n3 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -187,6 +187,7 @@ en: | |
contact: "Contact" | ||
website: "My website/blog:" | ||
city: "My city:" | ||
country: "My country" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. could you also please add that field to the German locale? country: "Land" |
||
twitter: "My twitter handle:" | ||
show: "Show" | ||
edit: "Edit profile" | ||
|
@@ -207,6 +208,7 @@ en: | |
twitter: "Twitter" | ||
topics: "Topics" | ||
city: "City" | ||
country: "Country" | ||
language: "Language" | ||
new: | ||
new_profile: "New Profile" | ||
|
@@ -252,6 +254,7 @@ en: | |
talks: "Talks" | ||
languages: "Languages<br><small>Please add programming languages in 'Topics', not here</small>" | ||
city: "City" | ||
country: "Country" | ||
twitter: "Twitter" | ||
picture: "Picture" | ||
translation: "<strong>You can fill in your maintopic and your bio both in German and English:</strong>" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
class AddColumnToProfiles < ActiveRecord::Migration | ||
def change | ||
add_column :profiles, :country, :string | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you change the displayed information into the country name of the corresponding locale? Currently if I chose "Germany" as a country in the profile show action "DE" is displayed. It would be cool if I would see "Deutschland" in the german locale, "Germany" in the english and "Alemanha" (in the future Portuguese locale)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is still looking the same. You might have to add that to the Profile Model: https://github.com/stefanpenner/country_select#getting-the-country-name-from-the-countries-gem