Add headers for pods #54

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

barrettclark commented Dec 12, 2013

I'm not sure how robust this is, but the specs pass and it's working in my project. The use case is that I need to be able to use one of my pods in an outlet.

Contributor

ainame commented Feb 4, 2014

@barrettclark
Sorry for my late reply.

This feature looks good to me. But, your implementation is not good.
Because, framework_headers method exists to output header information of Frameworks,
so you should add code in new method(e.g. named pod_libraries_header).

Please more refactoring your changeset and add some unit tests, then I will merge this :)

Contributor

barrettclark commented Mar 23, 2014

I'm going to leave this be for now. To really implement it well it would take digging in and recognizing all the delegate methods as well. Those get blown away each time the stub is regenerated. I've also started leaning towards not using interface builder with rubymotion.—
Sent from Mailbox for iPhone

On Tue, Feb 4, 2014 at 7:26 AM, Satoshi Namai notifications@github.com
wrote:

@barrettclark
Sorry for my late reply.
This feature looks good to me. But, your implementation is not good.
Because, framework_headers method exists to output header information of Frameworks,
so you should add code in new method(e.g. named pod_libraries_header).

Please more refactoring your changeset and add some unit tests, then I will merge this :)

Reply to this email directly or view it on GitHub:
yury#54 (comment)

ainame closed this Mar 25, 2014

Contributor

ainame commented Mar 25, 2014

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment