From 368c6f4a2525282a9cc0ea5aaf8de24de952916e Mon Sep 17 00:00:00 2001 From: Anna Velentsevich Date: Sat, 27 Mar 2021 11:12:04 +0300 Subject: [PATCH 01/10] first homework --- Velentsevich-Anna/1/test1.rb | 1 + 1 file changed, 1 insertion(+) create mode 100644 Velentsevich-Anna/1/test1.rb diff --git a/Velentsevich-Anna/1/test1.rb b/Velentsevich-Anna/1/test1.rb new file mode 100644 index 00000000..b85a0422 --- /dev/null +++ b/Velentsevich-Anna/1/test1.rb @@ -0,0 +1 @@ +puts "Hello World" From 4c70ea5c52d6c4c3040068529c26b594e5ce37f7 Mon Sep 17 00:00:00 2001 From: Anna Velentsevich Date: Sat, 27 Mar 2021 11:15:21 +0300 Subject: [PATCH 02/10] test --- test.rb | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 test.rb diff --git a/test.rb b/test.rb new file mode 100644 index 00000000..9e3bc98b --- /dev/null +++ b/test.rb @@ -0,0 +1,2 @@ +q + From bced82ad2923acc018c45275eb97003b552016bb Mon Sep 17 00:00:00 2001 From: Anna Velentsevich Date: Wed, 31 Mar 2021 14:50:53 +0300 Subject: [PATCH 03/10] testing hound --- test.rb | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/test.rb b/test.rb index 9e3bc98b..0f7aace9 100644 --- a/test.rb +++ b/test.rb @@ -1,2 +1,10 @@ q +a = 1 +b = 2 +if a and b + a = a + 1 + b = b - 1 +end + +puts 'a + b = ' + (a + b).to_s From 00d00d6227a92526271c9ae6d310736ccea65a97 Mon Sep 17 00:00:00 2001 From: Anna Velentsevich Date: Wed, 31 Mar 2021 18:55:37 +0300 Subject: [PATCH 04/10] Test rubocop --- test.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test.rb b/test.rb index 0f7aace9..1e87b8bf 100644 --- a/test.rb +++ b/test.rb @@ -1,4 +1,4 @@ -q + a = 1 b = 2 From 2b28384755614e42e0d7ea56b790e94025a6e71c Mon Sep 17 00:00:00 2001 From: Anna Velentsevich Date: Wed, 31 Mar 2021 23:07:14 +0300 Subject: [PATCH 05/10] More DESTRUPTION --- test.rb | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/test.rb b/test.rb index 1e87b8bf..29817325 100644 --- a/test.rb +++ b/test.rb @@ -1,10 +1,10 @@ -a = 1 -b = 2 -if a and b - a = a + 1 - b = b - 1 -end + a = 1 + b = 2 + if a and b + a = a + 1 + b = b - 1 + end -puts 'a + b = ' + (a + b).to_s + puts 'a + b = ' + (a + b).to_s From c2efa83a3804235248d3ec481e7818ba3caf5698 Mon Sep 17 00:00:00 2001 From: Anna Velentsevich Date: Wed, 31 Mar 2021 23:11:15 +0300 Subject: [PATCH 06/10] Trigger github actions on PR --- .github/workflows/reviews.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/reviews.yml b/.github/workflows/reviews.yml index 5f58aff6..39da895d 100644 --- a/.github/workflows/reviews.yml +++ b/.github/workflows/reviews.yml @@ -1,6 +1,6 @@ name: Code review on: -- push +- pull_request jobs: run: runs-on: ubuntu-latest From e43689d824351cc2a126a45de3d203e366068e9c Mon Sep 17 00:00:00 2001 From: Anna Velentsevich Date: Wed, 31 Mar 2021 23:16:12 +0300 Subject: [PATCH 07/10] Less destruption --- test.rb | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/test.rb b/test.rb index 29817325..5933ffd9 100644 --- a/test.rb +++ b/test.rb @@ -1,10 +1,8 @@ +a = 1 +b = 2 +if a && b + a += 1 + b -= 1 +end - - a = 1 - b = 2 - if a and b - a = a + 1 - b = b - 1 - end - - puts 'a + b = ' + (a + b).to_s +puts 'a + b = ' + (a + b).to_s From 1ad56e40b3d44cb69918d1d12bae83c55a892c0d Mon Sep 17 00:00:00 2001 From: Anna Velentsevich Date: Thu, 1 Apr 2021 11:02:13 +0300 Subject: [PATCH 08/10] testing --- test-2.rb | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 test-2.rb diff --git a/test-2.rb b/test-2.rb new file mode 100644 index 00000000..2dd83396 --- /dev/null +++ b/test-2.rb @@ -0,0 +1,6 @@ +a = b = 3 + +if a and b + puts "HEY" + a = a + 1 +end From bf54d0ec0e8e0b33b0266b0b5dd8afdf29c90947 Mon Sep 17 00:00:00 2001 From: Anna Velentsevich Date: Thu, 1 Apr 2021 18:55:28 +0300 Subject: [PATCH 09/10] changes at review.yml --- .github/workflows/reviews.yml | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/.github/workflows/reviews.yml b/.github/workflows/reviews.yml index 39da895d..f9618b15 100644 --- a/.github/workflows/reviews.yml +++ b/.github/workflows/reviews.yml @@ -1,6 +1,6 @@ name: Code review on: -- pull_request +- [push, pull_request] jobs: run: runs-on: ubuntu-latest @@ -11,14 +11,11 @@ jobs: fetch-depth: 0 - run: | git fetch --no-tags --prune origin - - uses: borales/actions-yarn@v2.0.0 - with: - cmd: install - - uses: adwerx/pronto-ruby@v2.5 + - uses: adwerx/pronto-ruby@v2.9 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} RUBOCOP_CONFIG: ./pronto/rubocop/rubocop.yml - YAMLLINT_OPTS: -c ./pronto/yamllint/yamllint.yml with: runners: >- - brakeman eslint_npm fasterer poper rails_best_practices rails_schema reek rubocop scss yamllint + brakeman rails_best_practices reek rubocop + \ No newline at end of file From a3d1b51e296a4a9093265f0d9abe221040059e5b Mon Sep 17 00:00:00 2001 From: Anna Velentsevich Date: Thu, 1 Apr 2021 18:57:50 +0300 Subject: [PATCH 10/10] okay this should be better --- .github/workflows/reviews.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/reviews.yml b/.github/workflows/reviews.yml index f9618b15..e9aa9fef 100644 --- a/.github/workflows/reviews.yml +++ b/.github/workflows/reviews.yml @@ -1,6 +1,5 @@ name: Code review -on: -- [push, pull_request] +on: [push, pull_request] jobs: run: runs-on: ubuntu-latest @@ -18,4 +17,3 @@ jobs: with: runners: >- brakeman rails_best_practices reek rubocop - \ No newline at end of file