GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
This will redirect users to the current slug URL for URLs with id in them
Redirects to canonical URLs
Please don't do this :-)
Oops, RubyMine autoformat
You should disable that ;-)
Why don't you just check the URL rather than the entire body?
response.url.should include(forum_topic_path(topic.forum, topic), I think.
response.url.should include(forum_topic_path(topic.forum, topic)
Why don't we respond with 404 then? :-)
If you guys are OK with it, I can make a separate pull request
I am not sure why it's there in the first place
Yep a 404 seems reasonable to me -- @radar @knewter ?
yeah, 404 on recordnotfound is standard and without argument against can't imagine having an issue with it :) :)
Agree, a 404 is best.
Thanks - just reviewed it and added a couple pieces of feedback.