FIx for Issue #301 #373

Closed
wants to merge 1 commit into
from

Projects

None yet

6 participants

@0xCCD
0xCCD commented Jan 30, 2013

No description provided.

@parndt
Contributor
parndt commented Jan 30, 2013

@radar @knewter @robyurkowski can you forsee any issues with this patch?

@radar
Collaborator
radar commented Jan 30, 2013

No, I can't foresee any issues with this patch.

I think that we should go the way that Spree's solving this problem: defining a top-level Spree JavaScript variable and then defining routes underneath that. That way, we wouldn't need this ugly Journey hack in place.

@parndt
Contributor
parndt commented Jan 30, 2013

Plus then we'd have support for any sub URI cleanly and with only exposing specific routes.

@knewter
Contributor
knewter commented Jan 31, 2013

+1
On Jan 30, 2013 5:59 PM, "Philip Arndt" notifications@github.com wrote:

Plus then we'd have support for any sub URI cleanly and with only exposing
specific routes.


Reply to this email directly or view it on GitHubhttps://github.com/radar/forem/pull/373#issuecomment-12919906.

@radar
Collaborator
radar commented Feb 6, 2013

I've got a branch called members-select2 which is implementing this. It currently doesn't allow you to actually add a member, which is problematic. To be looked at later.

@radar radar referenced this pull request Feb 13, 2013
Closed

Adding members of the group #354

@knewter
Contributor
knewter commented Apr 15, 2013

@radar @parndt So is the strategy to close this PR and await the top level js variable? Is there an issue open for doing that?

@radar
Collaborator
radar commented Apr 16, 2013

@knewter: Yes, a top-level variable would be best. I don't think there's an open issue for fixing that other than #301.

@radar radar closed this Apr 16, 2013
@daniely
daniely commented Jul 17, 2013

the link to defining routes by @radar is gone. i believe this is the correct link

@bodrovis
Contributor

I am sorry, but was that ever fixed? I got the following error when visiting "Add a new member page": TypeError: $(...).select2 is not a function (I have created a brand new application with the latest Forem). Adding gem "select2-rails" directly to my Gemfile, //= require select2 to application.js and @import 'select2.css.scss'; to application.css.scss actually fixes this and everything works fine.

@bodrovis
Contributor

Oh, I just added //= require forem to application.js and @import 'forem/base.css'; to application.css.scss. This should be mentioned somewhere in the docs probably?

@radar
Collaborator
radar commented Nov 21, 2013

@bodrovis Yes, it should definitely be mentioned in the docs. Please submit a patch to fix that.

@bodrovis
Contributor

@radar Done: #502

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment