Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upReverts breaking behaviour introduced in v2.1.4 #277
Conversation
dmcnally
added some commits
Nov 10, 2015
dmcnally
referenced this pull request
Nov 10, 2015
Open
v2.1.4 breaks backwards compatibility with v2.1.3 #276
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
dmcnally
Nov 13, 2015
@radar any ideas on when this might be merged? Or feedback on any other changes that are needed?
dmcnally
commented
Nov 13, 2015
|
@radar any ideas on when this might be merged? Or feedback on any other changes that are needed? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
radar
Nov 15, 2015
Collaborator
If it's affecting you now then you can run on a fork of paranoia until it gets merged. I will merge it when I merge it.
|
If it's affecting you now then you can run on a fork of paranoia until it gets merged. I will merge it when I merge it. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
radar
Nov 15, 2015
Collaborator
I am not paid to work on open source at all. Emails like this just increase the guilt I feel when I try to relax on the weekends. Emails like this make me want to not maintain paranoia at all.
|
I am not paid to work on open source at all. Emails like this just increase the guilt I feel when I try to relax on the weekends. Emails like this make me want to not maintain paranoia at all. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
rpaulo
Nov 16, 2015
Sigh, if you're sick of open source just don't blow up on some guys' PR. It looks like you haven't really considered the cost of working on open source when you started. It happens to us all, just don't take it personally.
rpaulo
commented
Nov 16, 2015
|
Sigh, if you're sick of open source just don't blow up on some guys' PR. It looks like you haven't really considered the cost of working on open source when you started. It happens to us all, just don't take it personally. |
leklund
referenced this pull request
Dec 7, 2015
Open
Fix uniqueness validator for non-paranoid models. #256
added a commit
to leklund/paranoia
that referenced
this pull request
Dec 7, 2015
leklund
referenced this pull request
Dec 8, 2015
Open
Revert breaking behavior introduced by #122 #286
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jhawthorn
Feb 2, 2016
Collaborator
This is not so simple, and is a bit of a pickle.
Though 2.1.4 had a breaking change for 2.1.3 users it should not have had for a minor version, reverting it would be a be a breaking change for current 2.1.4 and 2.1.5 users. To achieve compatibility with both we'll have to add some sort of configuration.
|
This is not so simple, and is a bit of a pickle. Though 2.1.4 had a breaking change for 2.1.3 users it should not have had for a minor version, reverting it would be a be a breaking change for current 2.1.4 and 2.1.5 users. To achieve compatibility with both we'll have to add some sort of configuration. |
dmcnally commentedNov 10, 2015
Removed the patch to
ActiveRecord::Validations::UniquenessValidatoras it caused breaking changes.See ticket #276
Test updated to reflect old behaviour