Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts breaking behaviour introduced in v2.1.4 #277

Closed
wants to merge 2 commits into from

Conversation

@dmcnally
Copy link

dmcnally commented Nov 10, 2015

Removed the patch to ActiveRecord::Validations::UniquenessValidator as it caused breaking changes.

See ticket #276

Test updated to reflect old behaviour

@dmcnally
Copy link
Author

dmcnally commented Nov 13, 2015

@radar any ideas on when this might be merged? Or feedback on any other changes that are needed?

@radar
Copy link
Collaborator

radar commented Nov 15, 2015

If it's affecting you now then you can run on a fork of paranoia until it gets merged. I will merge it when I merge it.

@radar
Copy link
Collaborator

radar commented Nov 15, 2015

I am not paid to work on open source at all. Emails like this just increase the guilt I feel when I try to relax on the weekends. Emails like this make me want to not maintain paranoia at all.

@rpaulo
Copy link

rpaulo commented Nov 16, 2015

Sigh, if you're sick of open source just don't blow up on some guys' PR. It looks like you haven't really considered the cost of working on open source when you started. It happens to us all, just don't take it personally.

@jhawthorn
Copy link
Collaborator

jhawthorn commented Feb 2, 2016

This is not so simple, and is a bit of a pickle.

Though 2.1.4 had a breaking change for 2.1.3 users it should not have had for a minor version, reverting it would be a be a breaking change for current 2.1.4 and 2.1.5 users. To achieve compatibility with both we'll have to add some sort of configuration.

@jhawthorn jhawthorn closed this Feb 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.