Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit language about dependent: :destroy #367

Merged
merged 1 commit into from Nov 29, 2016

Conversation

@supremebeing7
Copy link
Contributor

commented Nov 29, 2016

My team and I had a lengthy conversation about this because there were different interpretations of what the README meant. This may be beating a dead horse a bit, but I think it's an important enough piece of this great gem that it merits perhaps a little bit extra verbosity to make sure it's well understood.

@BenMorganIO

This comment has been minimized.

Copy link
Collaborator

commented Nov 29, 2016

I like it 👍

@BenMorganIO BenMorganIO merged commit 77413f1 into rubysherpas:core Nov 29, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@supremebeing7 supremebeing7 deleted the supremebeing7:patch-1 branch Nov 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.