New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure callback is called on destroy #432

Closed
wants to merge 2 commits into
base: core
from

Conversation

Projects
None yet
1 participant
@koenpunt

koenpunt commented Jan 3, 2018

Inspired by how the destroy callback is ensured in acts_as_paranoid, we now flag the record to be triggering the update callback if the delete succeeded.

Altho while at it, it might be even better to actually set @_trigger_destroy_callback to true.

Probably need to add tests too.

@koenpunt koenpunt closed this Jan 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment