New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which rubysl-foo gem is required for rspec autodetection? #7

Closed
sodabrew opened this Issue Nov 30, 2013 · 12 comments

Comments

Projects
None yet
4 participants
@sodabrew

sodabrew commented Nov 30, 2013

Using full rubysl, rspec finds and runs my specs. Using only rubysl-rake, specs are not executed: https://travis-ci.org/sodabrew/mysql2/jobs/14727467

Without putting me through a search of every rubysl-foo gem, can you point at the one I need for rspec to do its magic? Thanks!

@sodabrew

This comment has been minimized.

sodabrew commented Nov 30, 2013

rubysl-rake + rubysl-drb + rubysl-bigdecimal does the trick. Shall I submit a PR for 'rubysl-rspec' convenience gem?

@brixen

This comment has been minimized.

Contributor

brixen commented Dec 1, 2013

@sodabrew sure, a PR for rubyl-rspec would be great.

Curious, did you have an issue using 'rubysl' or did you just want to restrict the number of gems pulled in? I certainly agree with the latter but wanted to make sure you didn't have an issue we can fix directly.

@sodabrew

This comment has been minimized.

sodabrew commented Dec 1, 2013

Wanted to restrict the number of gems to speed up Travis runs :)

@brixen

This comment has been minimized.

Contributor

brixen commented Dec 1, 2013

@sodabrew yeah, sounds good. :)

@JonRowe

This comment has been minimized.

JonRowe commented Dec 10, 2013

From rspec/rspec-rails#871 please note you'll need rubysl-test-unit if running rspec-rails.

@sodabrew

This comment has been minimized.

sodabrew commented Dec 10, 2013

Doesn't test-unit conflict with minitest? I wouldn't want to cause an autoload clash.

@JonRowe

This comment has been minimized.

JonRowe commented Dec 10, 2013

Minitest is a gem, test-unit is part of the Ruby standard library. Rails (and thus rspec-rails) has a dependency on test-unit which will cause rspec to blow up if you're running Rubinius without rubysl-test-unit.

@sodabrew

This comment has been minimized.

sodabrew commented Dec 10, 2013

Ack. I'll be sure to include it :)

@JonRowe

This comment has been minimized.

JonRowe commented Dec 11, 2013

Note I said rspec-rails e.g. it may be worth having two gems if you're going down that route... also are you planning on having RSpec as a dependency of this/these gems? or is just a convenience factor for Rubinius devs?

@YorickPeterse

This comment has been minimized.

Member

YorickPeterse commented Dec 17, 2014

Considering rubysl is now always available, even when using Bundler, I'm closing this one. There should no longer be a need to add rubysl to your Gemfile.

@sodabrew

This comment has been minimized.

sodabrew commented Dec 18, 2014

Oh, awesome. As of which rbx release?

@YorickPeterse

This comment has been minimized.

Member

YorickPeterse commented Dec 18, 2014

I believe that change was made in 2.2.10 or one release before it, so it's been there for a little while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment