Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix evalutating expressions including percentage operator(modulo with… #167

Closed
wants to merge 1 commit into from

Conversation

jarkonik
Copy link
Contributor

@jarkonik jarkonik commented Jun 1, 2018

… arity == 1)

It caused crashes in /lib/dentaku/ast/operation.rb:14:in `dependencies' for expressions like 5%

@codecov-io
Copy link

codecov-io commented Jun 1, 2018

Codecov Report

Merging #167 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
+ Coverage   96.18%   96.19%   +0.01%     
==========================================
  Files          53       53              
  Lines        1338     1342       +4     
==========================================
+ Hits         1287     1291       +4     
  Misses         51       51
Impacted Files Coverage Δ
lib/dentaku/ast/arithmetic.rb 95.23% <100%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c190a5...2f2ee1c. Read the comment docs.

@rubysolo rubysolo closed this in 5327692 Jun 1, 2018
@rubysolo
Copy link
Owner

rubysolo commented Jun 1, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants