Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some gems #73

Merged
merged 4 commits into from Mar 10, 2018

Conversation

Projects
None yet
2 participants
@westonganger
Copy link
Contributor

commented Feb 17, 2018

No description provided.

westonganger added some commits Feb 17, 2018

@westonganger westonganger changed the title Add rearmed Add some gems Feb 17, 2018

@colszowka colszowka referenced this pull request Feb 21, 2018

Closed

Add spreadsheet_architect #72

@colszowka

This comment has been minimized.

Copy link
Member

commented Feb 21, 2018

Thanks!

"Rails extensions" seems quite broad, can we find a slightly more descriptive name? Also, do you know similar libraries so we have at least two projects in that category?

@westonganger

This comment has been minimized.

Copy link
Contributor Author

commented Feb 21, 2018

I was just following the convention provided by Ruby Core Extensions. Would it be better to call it Rails Core Extensions. I don't know of any other libraries, most similar libraries usually have to do with ActiveRecord only, mine patches both Rails & ActiveRecord.

@colszowka

This comment has been minimized.

Copy link
Member

commented Feb 21, 2018

@westonganger Yeah, I also thought of Ruby Core Extensions, but that one has a bit more of a tradition in the ruby community by means of active_support/core_ext

Let's leave it as-is, once the category is there maybe someone else will chip in and suggest more projects for this :)

@colszowka

This comment has been minimized.

Copy link
Member

commented Feb 21, 2018

@westonganger One more thing, could you please provide a description for the new category? I know most of the existing ones do not have one either, but I'd like to add them over time :)

@westonganger

This comment has been minimized.

Copy link
Contributor Author

commented Feb 21, 2018

Okay I have now added the description for the Rails Extensions category.

@colszowka colszowka merged commit 13a9d51 into rubytoolbox:master Mar 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@colszowka

This comment has been minimized.

Copy link
Member

commented Mar 10, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.