Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search polish #109

Closed
colszowka opened this issue Jan 29, 2018 · 1 comment
Closed

Search polish #109

colszowka opened this issue Jan 29, 2018 · 1 comment

Comments

@colszowka
Copy link
Member

@colszowka colszowka commented Jan 29, 2018

Followup to #84 to do some non-MVP-but-still-nice-to-have additions for the search:

  • More expansive tests - Via #372 and #375
  • Result Pagination - Via #375
  • When submitting an empty form on desktop, the page is very bleak. It should show at least some "please add a query message or so". On mobile this problem is not that prominent since the search input form is full-width and large there. - Via #376
  • Similar issue when submitting a query with 0 results - Via #376
  • Focus the form input on initial access (or empty query) on mobile - Via #376
  • Put the button into bulma's loading state after submit - Via #376
@colszowka
Copy link
Member Author

@colszowka colszowka commented Jan 10, 2019

Adressed via #372, #375 and #376, closing. Further improvements to search, i.e. relating to result relevance, will take place in separate, future PRs.

@colszowka colszowka closed this Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant