New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search polish #109

Open
colszowka opened this Issue Jan 29, 2018 · 0 comments

Comments

1 participant
@colszowka
Member

colszowka commented Jan 29, 2018

Followup to #84 to do some non-MVP-but-still-nice-to-have additions for the search:

  • More expansive tests
  • Result Pagination
  • Show some stats regarding the search (at least total results)
  • When submitting an empty form on desktop, the page is very bleak. It should show at least some "please add a query message or so". On mobile this problem is not that prominent since the search input form is full-width and large there.
  • Similar issue when submitting a query with 0 results
  • Focus the form input on initial access (or empty query) on mobile
  • Put the button into bulma's loading state after submit
  • Disable form autocompletion on the search input

@colszowka colszowka created this issue from a note in Ruby Toolbox (Backlog) Jan 29, 2018

@colszowka colszowka referenced this issue Jan 29, 2018

Merged

Search #84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment