New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Comparisons #408

Merged
merged 9 commits into from Feb 14, 2019

Conversation

Projects
None yet
1 participant
@colszowka
Copy link
Member

colszowka commented Jan 31, 2019

Following shortly to the new alternate display modes via #398 this PR adds a new feature that allows users to compare arbitrary projects using the usual project sorting / display modes, with the comparison pages being deep-linkable too.

The ability to compare arbitrary projects side by side came in in 3rd place in the recent community survey feature vote.

Since the top navigation became too crowded to fit all the content in the desktop breakpoint (~1024-1280px) I had to also tweak the responsiveness of the navigation a bit.

I'm not fully happy yet with how the display settings and consistent URL generation works at the moment, but I'll save that for a followup refactoring PR, it's tested and works, it just feels a bit brittle and similar logic is sprinkled across 3 different controllers, the view helpers and some view templates now, there must be a better way to do this :)

project-comparisons-cut

@colszowka colszowka force-pushed the co-comparison branch from 665a40c to 43fd21c Feb 13, 2019

@colszowka colszowka force-pushed the co-comparison branch from 7257271 to cced3af Feb 14, 2019

@colszowka colszowka merged commit a28c539 into master Feb 14, 2019

3 checks passed

ci/circleci: prepare Your tests passed on CircleCI!
Details
ci/circleci: rubocop Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details

@colszowka colszowka deleted the co-comparison branch Feb 14, 2019

colszowka added a commit that referenced this pull request Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment