Work with preloaders #6
Comments
|
With spring, can use guard :minitest, spring: true, cli: '| tapout pretty' do
# Rails 4
watch(%r{^app/(.+)\.rb}) { |m| "test/#{m[1]}_test.rb" }
watch(%r{^app/controllers/application_controller\.rb}) { 'test/controllers' }
watch(%r{^app/controllers/(.+)_controller\.rb}) { |m| "test/integration/#{m[1]}_test.rb" }
watch(%r{^app/views/(.+)_mailer/.+}) { |m| "test/mailers/#{m[1]}_mailer_test.rb" }
watch(%r{^lib/(.+)\.rb}) { |m| "test/lib/#{m[1]}_test.rb" }
watch(%r{^test/.+_test\.rb})
watch(%r{^test/test_helper\.rb}) { 'test' }
end |
|
@trans Sorry for my questions, minitap can't work with pry, if use ruby -Itest test/models/post_test.rb | tapout
exit
/Users/doabit/.rbenv/versions/2.0.0-p247/gemsets/4.1.0.beta/gems/psych-2.0.1/lib/psych.rb:369:in `parse': (<unknown>): control characters are not allowed at line 1 column 1 (Psych::SyntaxError)
from /Users/doabit/.rbenv/versions/2.0.0-p247/gemsets/4.1.0.beta/gems/psych-2.0.1/lib/psych.rb:369:in `parse_stream'
from /Users/doabit/.rbenv/versions/2.0.0-p247/gemsets/4.1.0.beta/gems/psych-2.0.1/lib/psych.rb:317:in `parse'
from /Users/doabit/.rbenv/versions/2.0.0-p247/gemsets/4.1.0.beta/gems/psych-2.0.1/lib/psych.rb:244:in `load'
from /Users/doabit/.rbenv/versions/2.0.0-p247/gemsets/4.1.0.beta/gems/tapout-0.4.2/lib/tapout/parsers/yaml.rb:47:in `handle'
from /Users/doabit/.rbenv/versions/2.0.0-p247/gemsets/4.1.0.beta/gems/tapout-0.4.2/lib/tapout/parsers/yaml.rb:34:in `<<'
from /Users/doabit/.rbenv/versions/2.0.0-p247/gemsets/4.1.0.beta/gems/tapout-0.4.2/lib/tapout/parsers/yaml.rb:24:in `consume'
from /Users/doabit/.rbenv/versions/2.0.0-p247/gemsets/4.1.0.beta/gems/tapout-0.4.2/lib/tapout/cli.rb:80:in `cli'
from /Users/doabit/.rbenv/versions/2.0.0-p247/gemsets/4.1.0.beta/gems/tapout-0.4.2/bin/tapout:3:in `<top (required)>'
from /Users/doabit/.rbenv/versions/2.0.0-p247/gemsets/4.1.0.beta/bin/tapout:23:in `load'
from /Users/doabit/.rbenv/versions/2.0.0-p247/gemsets/4.1.0.beta/bin/tapout:23:in `<main>'post_test.rb require 'test_helper'
class PostTest < ActiveSupport::TestCase
test "the truth" do
@post = Fabricate(:post)
assert @post.valid?
binding.pry
end
end |
|
Take off the |
|
Btw, what's happening is you're piping pry's interface into tapout, and tapout is trying to interpret that as TAP-Y/J test output. I probably can teach tapout to stop when it hits a document end marker, i.e. |
|
Take off the | tapout, it works, ---
type: suite
start: '2013-11-18 00:23:45'
count: 18
seed: 62546
rev: 4
From: /Users/doabit/Sites/test/rails/tmp/minit/blog/test/models/post_test.rb @ line 7 PostTest#test_the_truth:
4: test "the truth" do
5: @post = Fabricate(:post)
6: assert @post.valid?
=> 7: binding.pry
8: endexit
/Users/doabit/.rbenv/versions/2.0.0-p247/gemsets/4.1.0.beta/gems/psych-2.0.1/lib/psych.rb:369:in `parse': (<unknown>): control characters are not allowed at line 1 column 1 (Psych::SyntaxError)
from /Users/doabit/.rbenv/versions/2.0.0-p247/gemsets/4.1.0.beta/gems/psych-2.0.1/lib/psych.rb:369:in `parse_stream'
from /Users/doabit/.rbenv/versions/2.0.0-p247/gemsets/4.1.0.beta/gems/psych-2.0.1/lib/psych.rb:317:in `parse'
from /Users/doabit/.rbenv/versions/2.0.0-p247/gemsets/4.1.0.beta/gems/psych-2.0.1/lib/psych.rb:244:in `load'
from /Users/doabit/.rbenv/versions/2.0.0-p247/gemsets/4.1.0.beta/gems/tapout-0.4.2/lib/tapout/parsers/yaml.rb:47:in `handle'
from /Users/doabit/.rbenv/versions/2.0.0-p247/gemsets/4.1.0.beta/gems/tapout-0.4.2/lib/tapout/parsers/yaml.rb:34:in `<<'
from /Users/doabit/.rbenv/versions/2.0.0-p247/gemsets/4.1.0.beta/gems/tapout-0.4.2/lib/tapout/parsers/yaml.rb:24:in `consume'
from /Users/doabit/.rbenv/versions/2.0.0-p247/gemsets/4.1.0.beta/gems/tapout-0.4.2/lib/tapout/cli.rb:80:in `cli'
from /Users/doabit/.rbenv/versions/2.0.0-p247/gemsets/4.1.0.beta/gems/tapout-0.4.2/bin/tapout:3:in `<top (required)>'
from /Users/doabit/.rbenv/versions/2.0.0-p247/gemsets/4.1.0.beta/bin/tapout:23:in `load'
from /Users/doabit/.rbenv/versions/2.0.0-p247/gemsets/4.1.0.beta/bin/tapout:23:in `<main>'With spring, it couldn't work, either with |
|
Hmm... is spring+pry working when you don't use tap output? |
|
Yes, i also tested |
|
It pipes the output as it happens. If it waited then nothing would output until the very end, after all tests were run. Not sure why it shouldn't work with spring if the output is not being piped to tapout. It's just a standard Minitest reporter, so it should work with anything. But then I am not sure how spring works. Did you say that minitap + spring works okay w/o pry in the mix? |
|
Yes, if not use minitap, everything works well, i also can work with spring + pry + minitest-reporters. I thought, minitap reuturn json or yml fomat result, but when tests stoped, would get JSON::ParserError or (Psych::SyntaxError) exit
/Users/doabit/.rbenv/versions/2.0.0-p247/gemsets/4.1.0.beta/gems/json-1.8.1/lib/json/common.rb:155:in
`parse': 795: unexpected token at '{"type"=>"suite", "start"=>"2013-11-18 01:01:50", "count"=>18, "seed"=>56585, "rev"=>4} (JSON::ParserError) |
|
Pry with minitest-reporterts Started
PostTest
[WARN] cannot load such file -- awesome_print
$ gem install awesome_print
From: /Users/doabit/Sites/test/rails/tmp/minit/blog/test/models/post_test.rb @ line 7 PostTest#test_the_truth:
4: test "the truth" do
5: @post = Fabricate(:post)
6: assert @post.valid?
=> 7: binding.pry
8: end
[1] pry(#<PostTest>)> exit
test_the_truth PASS (2.18s)
PostsControllerTest
test_should_create_post PASS (0.02s)
test_should_destroy_post PASS (0.01s)
test_should_get_edit PASS (0.04s)
test_should_get_index PASS (0.01s)
test_should_get_new PASS (0.05s)
test_should_show_post PASS (0.01s)
test_should_update_post PASS (0.01s)
PostsTest
test_the_truth PASS (0.05s)
UserTest
test_the_truth PASS (0.00s)
UsersControllerTest
test_should_create_user PASS (0.02s)
test_should_destroy_user PASS (0.01s)
test_should_get_edit PASS (0.01s)
test_should_get_index PASS (0.01s)
test_should_get_new PASS (0.01s)
test_should_show_user PASS (0.01s)
test_should_update_user PASS (0.01s)
UsersTest
test_login_player PASS (0.03s)
Finished in 2.48854s
18 tests, 30 assertions, 0 failures, 0 errors, 0 skipsSpring + pry + minitest-reporters Started
PostTest
[WARN] cannot load such file -- awesome_print
$ gem install awesome_print
From: /Users/doabit/Sites/test/rails/tmp/minit/blog/test/models/post_test.rb @ line 7 PostTest#test_the_truth:
4: test "the truth" do
5: @post = Fabricate(:post)
6: assert @post.valid?
=> 7: binding.pry
8: end
[1] pry(#<PostTest>)> exit
test_the_truth PASS (2.42s)
PostsControllerTest
test_should_create_post PASS (0.02s)
test_should_destroy_post PASS (0.01s)
test_should_get_edit PASS (0.09s)
test_should_get_index PASS (0.01s)
test_should_get_new PASS (0.01s)
test_should_show_post PASS (0.01s)
test_should_update_post PASS (0.01s)
PostsTest
test_the_truth PASS (0.05s)
UserTest
test_the_truth PASS (0.00s)
UsersControllerTest
test_should_create_user PASS (0.02s)
test_should_destroy_user PASS (0.01s)
test_should_get_edit PASS (0.01s)
test_should_get_index PASS (0.01s)
test_should_get_new PASS (0.05s)
test_should_show_user PASS (0.01s)
test_should_update_user PASS (0.01s)
UsersTest
test_login_player PASS (0.02s)
Finished in 2.77927s
18 tests, 30 assertions, 0 failures, 0 errors, 0 skips |
|
Yea, it makes perfect sense why Pry doesn't work when piping output to tapout. Unlike minitest-reporters which just integrates itself into minitest so there is only one program running, with minitap we have two different programs running, minitest and tapout, and they are communicating via a pipe --the output from minitest is being passed into tapout, and tapout is interpreting that input as tap-y/j formatted test output. If suddenly some other data comes across the pipe, e.g. a Pry command prompt, tapout cannot interpret that and a YAML or JSON syntax error is going to happen. I have an idea that should work around this, see rubyworks/tapout#6. But I still have to figure out the details which may take a bit of time. However none of this explains why spring + minitap + pry doesn't work, just as long as the output is NOT being piped to the tapout command (no |
|
Got it, thanks for your job. |
|
Just released minitap-0.5.2 (along with tapout-0.4.3). For the most part this should resolve this issue and many related ones. For optimal results one should emit a DLE ASCII code ( test "the truth" do
@post = Fabricate(:post)
assert @post.valid?
STDOUT.puts 16.chr
binding.pry
STDOUT.puts 23.chr
endI use Note, this doesn't necessarily address spring + pry + minitap (but one can hope!), as there appears to be something else afoot there. Nonetheless I am going to go ahead can close this issue. We can start new more specific issues for anything that remains. |
|
Thanks, i have tested, but it looks still not work well exit
Started w/ Seed: 64378
From: /Users/doabit/Sites/test/rails/tmp/minit/mit/test/models/post_test.rb @ line 6 PostTest#test_the_truth:
4: test "the truth" do
5: STDOUT.puts "..." 0;34# tells tapout to pause processing
=> 6: binding.pry
7: STDOUT.puts "---"
8: assert true
9: end
---
---
type: case
subtype: ''
label: PostTest
level: 0
stdout: "$ gem install awesome_print\n\e[0G"
stderr: |
[WARN] cannot load such file -- awesome_print
---
type: test
subtype: ''
status: pass
label: test_the_truth
time: 1.295685
---
type: final
time: 1.296649
counts:
total: 1
pass: 1
fail: 0
error: 0
omit: 0
todo: 0
...I thought the main resean is tapout. Now the process is minitap -> tapout, if use |
|
It's just a bug in the yaml parser. It should work if you use |
|
I use rails deault Rakefile, if not use rails [1] pry(#<Destroying AR models>)> exit
Started w/ Seed: 3239
From: /Users/doabit/Sites/test/rails/tmp/minit/dd/test/main_test.rb @ line 8 Destroying AR models#test_0001_true test:
5: it "true test" do
6: assert true
7: STDOUT.puts "..." 0;34# tells tapout to pause processing
=> 8: binding.pry
9: STDOUT.puts "---"
10: end
---
---
type: case
subtype: ''
label: Destroying AR models
level: 0
stdout: "$ gem install awesome_print\n\e[0G"
stderr: |
[WARN] cannot load such file -- awesome_print
---
type: test
subtype: ''
status: pass
label: true test
time: 2.988121
---
type: test
subtype: ''
status: fail
label: fail test
exception:
message: Failed assertion, no message given.
class: Minitest::Assertion
file: test/main_test.rb
line: 13
source: assert false
snippet:
- 11: ''
- 12: ' it "fail test" do'
- 13: ' assert false'
- 14: ' end'
- 15: end
backtrace:
- test/main_test.rb:13
time: 2.989053
---
type: final
time: 2.990012
counts:
total: 2
pass: 1
fail: 1
error: 0
omit: 0
todo: 0
...test_helper.rb ENV["RACK_ENV"] = "test"
require "minitest"
require "minitest/autorun"
require "minitap"
Minitest.reporter = Minitap::TapY |
|
I have the YAML parser fixed and will release shorty. It turns out the new document marker isn't even needed to restart. But really the more robust solution is to use the codes def pry!(binding_of_caller)
STDOUT.puts 16.chr
binding_of_caller.pry
STDOUT.puts 23.chr
endThen use it: test "the truth" do
@post = Fabricate(:post)
assert @post.valid?
pry!(binding)
end |
|
Pushed tapout-0.4.4. |
|
I have tested, maybe my problem, it still not work, run stoped here: [1] pry(#<Destroying AR models>)>Then, input 1] pry(#<Destroying AR models>)> exit
From: /Users/doabit/Sites/test/rails/tmp/minit/dd/test/main_test.rb @ line 6 Destroying AR models#test_0001_true test:
5: it "true test" do
=> 6: pry!(binding)
7: assert true
8: end
Started w/ Seed: 15732
.
Finished in 2.693s (0.371 test/s, 2.692543s avg.)
1 tests: 1 pass, 0 fail, 0 errs, 0 todo, 0 omitI also tried to modify minitap like this def tapout_before_suite()
result = super().to_json
Tapout::JsonParser.new({format: 'dot', input: StringIO.new(result)})
endBut it not work, i'll try it again, thanks. |
|
That's confusing. Your output almost looks correct except somehow Pry stepped in before the @doabit I really appreciate all your help on this. You've already helped improve minitap/tapout in ways I did not think possible. Thank you. It's been a bit difficult to compare results b/c we are not working off the same code base. Do you think you can create a public test repo of a mock Rails project that we could both use for this? |
|
Awesome! That is a Huge help. I've already tracked down one issue that solves The other issue with |
|
I thought to use |
|
Not so, it doesn't have to return a complete json or yml. It's a data stream, so if everything is working as it should, it processes the stream continuously in discrete chunks, not all at once. I made some headway in understanding the problem. Have a look at pry/pry#1011 |
|
Oh, i see. I always thought $ rake test | tapoutStarted w/ Seed: 64378
From: /Users/doabit/Sites/test/rails/tmp/minit/mit/test/models/post_test.rb @ line 6 PostTest#test_the_truth:
4: test "the truth" do
5: STDOUT.puts "..." 0;34# tells tapout to pause processing
=> 6: binding.pry
7: STDOUT.puts "---"
8: assert true
9: end
---
type: test
subtype: ''
status: pass
label: test_the_truth
time: 1.295685
---
type: final
time: 1.296649
counts:
total: 1
pass: 1
fail: 0
error: 0
omit: 0
todo: 0
...It didn't format results. but YML. |
|
I am suddenly getting: when I run |
|
arel (~> 5.0.0) ? I should |
|
I had to rebundle. It's okay, I fixed by adding |
|
Oh, may be rails updated. It works in my computer |
|
Okay. Things are looking up, finally. Turns out it had nothing to do with Pry, Rails or Rake. All that was needed was to add |
|
Great, i have updated def pry!(binding_of_caller)
STDOUT.puts 16.chr
binding_of_caller.pry
STDOUT.puts 23.chr
endI thought many people may be more like to use |
|
I've been playing with some ways to improve on that, but it's just a matter of how things work. I don't think there is any way to avoid it all together. One idea: Another option is to override the Maybe just offering an alternative: |
|
Yes, that is indeed, Add it into README maybe the best way now. |
From issue #5:
"I have tried https://github.com/rubyworks/tapout/wiki/Quick-Start, but it can't work well with rails 4, i think to add config like Minitest::Reporters.use! Minitest::Reporters::SpecReporter.new would be great. then it could work with spring or zeus."
The text was updated successfully, but these errors were encountered: