Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RuboCop settings and apply automatic corrections #332

Merged
merged 3 commits into from Aug 2, 2017

Conversation

@aeroastro
Copy link
Contributor

@aeroastro aeroastro commented Jun 28, 2017

RuboCop was introduced by #226 2 years ago, but there are some missing settings.
In this PR, I would like to change the followings so that we can check code easily and correctly.

If we are not satisfied with default rubocop style, we can modify the rules at .rubocop.yml afterward.

@coveralls
Copy link

@coveralls coveralls commented Jun 28, 2017

Coverage Status

Coverage decreased (-68.4%) to 22.951% when pulling 26767e9 on aeroastro:feature/rubocop-update into 98f4f2e on rubyzip:master.

@aeroastro aeroastro force-pushed the aeroastro:feature/rubocop-update branch from 26767e9 to cf91112 Jun 29, 2017
@coveralls
Copy link

@coveralls coveralls commented Jun 29, 2017

Coverage Status

Coverage increased (+0.2%) to 91.535% when pulling cf91112 on aeroastro:feature/rubocop-update into 98f4f2e on rubyzip:master.

@simonoff simonoff merged commit 41fcf0a into rubyzip:master Aug 2, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 91.535%
Details
@aeroastro aeroastro deleted the aeroastro:feature/rubocop-update branch Oct 11, 2017
This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants