Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix for calling 'close' on a StringIO-backed zip file, and specs #353

Merged
merged 1 commit into from Mar 30, 2018

Conversation

@pnomolos
Copy link
Contributor

@pnomolos pnomolos commented Feb 21, 2018

Right now if you call Zip::File#close on a zipfile that's been opened with a StringIO you get an exception in on_success_replace. This fixes this since calling .close here should be a no-op anyway as there's no on-disk file to replace.

@coveralls
Copy link

@coveralls coveralls commented Feb 21, 2018

Coverage Status

Coverage increased (+3.7%) to 96.486% when pulling cadd48f on pnomolos:pnomolos/fix_stringio into 2f80da6 on rubyzip:master.

@coveralls
Copy link

@coveralls coveralls commented Feb 21, 2018

Coverage Status

Coverage increased (+3.8%) to 96.52% when pulling 792266d on pnomolos:pnomolos/fix_stringio into 2f80da6 on rubyzip:master.

1 similar comment
@coveralls
Copy link

@coveralls coveralls commented Feb 21, 2018

Coverage Status

Coverage increased (+3.8%) to 96.52% when pulling 792266d on pnomolos:pnomolos/fix_stringio into 2f80da6 on rubyzip:master.

@pnomolos pnomolos force-pushed the pnomolos:pnomolos/fix_stringio branch from cadd48f to 792266d Feb 23, 2018
@simonoff simonoff merged commit 05af123 into rubyzip:master Mar 30, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+3.8%) to 96.52%
Details
This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants