Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression caused by automatic Rubocop fixes #355

Merged
merged 1 commit into from Mar 30, 2018

Conversation

@pnomolos
Copy link
Contributor

@pnomolos pnomolos commented Feb 23, 2018

Zip::Entry.empty? doesn't exist, but Rubocop suggested it as a fix instead of size == 0. This particular instance only fails under very certain circumstances. I have a file that causes it to fail but it's an proprietary internal file that's automatically generated by one of our vendors so I'm unable to share it.

I only fixed this one specific instance, there may be other regressions caused by the Rubocop cleanup so perhaps the entire commit should be double-checked.

@coveralls
Copy link

@coveralls coveralls commented Feb 23, 2018

Coverage Status

Coverage increased (+3.8%) to 96.52% when pulling 5f43552 on pnomolos:pnomolos/fix-rubocop-breakage into 2f80da6 on rubyzip:master.

2 similar comments
@coveralls
Copy link

@coveralls coveralls commented Feb 23, 2018

Coverage Status

Coverage increased (+3.8%) to 96.52% when pulling 5f43552 on pnomolos:pnomolos/fix-rubocop-breakage into 2f80da6 on rubyzip:master.

@coveralls
Copy link

@coveralls coveralls commented Feb 23, 2018

Coverage Status

Coverage increased (+3.8%) to 96.52% when pulling 5f43552 on pnomolos:pnomolos/fix-rubocop-breakage into 2f80da6 on rubyzip:master.

@coveralls
Copy link

@coveralls coveralls commented Feb 23, 2018

Coverage Status

Coverage increased (+3.7%) to 96.412% when pulling ffd0b67 on pnomolos:pnomolos/fix-rubocop-breakage into 2f80da6 on rubyzip:master.

InputStream:

```
if @current_entry && @current_entry.gp_flags & 8 == 8 && @current_entry.crc == 0 \
  && @current_entry.compressed_size == 0 \
  && @current_entry.empty? && !@internal
```

`Zip::Entry#empty?` doesn't exist, but an automatic Rubocop check thought it should be converted from `size == 0`.

Unfortunately, this is tricky to write a test for as it only fails under some very specific conditions.
@pnomolos pnomolos force-pushed the pnomolos:pnomolos/fix-rubocop-breakage branch from 5f43552 to ffd0b67 Feb 23, 2018
@danielrhodes
Copy link

@danielrhodes danielrhodes commented Mar 30, 2018

Came here to patch the same thing! @olleolleolle @simonoff Could one of you merge this?

@simonoff simonoff merged commit c0a8ad9 into rubyzip:master Mar 30, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+3.7%) to 96.412%
Details
This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants