Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zip::File.add_stored() to add uncompressed files. #366

Merged
merged 1 commit into from Sep 15, 2019

Conversation

@hainesr
Copy link
Contributor

hainesr commented May 20, 2018

Adding uncompressed files to a zip archive can be overly complex, so this convenience method makes it easier. Examples of the confusion caused by the current situation are in #286 and sul-dlss/preservation_catalog#737.

@coveralls

This comment has been minimized.

Copy link

coveralls commented May 20, 2018

Coverage Status

Coverage increased (+0.0003%) to 99.836% when pulling ecb2776 on hainesr:add-stored into 09bb946 on rubyzip:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented May 20, 2018

Coverage Status

Coverage decreased (-3.9%) to 92.669% when pulling 0346e81 on hainesr:add-stored into 8887b70 on rubyzip:master.

Adding uncompressed files to a zip archive can be overly complex, so
this convenience method makes it easier.
@hainesr hainesr force-pushed the hainesr:add-stored branch from 0346e81 to ecb2776 Sep 14, 2019
@hainesr

This comment has been minimized.

Copy link
Contributor Author

hainesr commented Sep 14, 2019

I've rebased this onto head and all checks now pass. Do you think it's worth a look @jdleesmiller?

Copy link
Member

jdleesmiller left a comment

This does seem to come up fairly frequently, so I think it is a worthwhile addition to the API. 👍

@jdleesmiller jdleesmiller merged commit 6619bf3 into rubyzip:master Sep 15, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0003%) to 99.836%
Details
@hainesr hainesr deleted the hainesr:add-stored branch Sep 15, 2019
@JangJungAn

This comment has been minimized.

Copy link

JangJungAn commented on ecb2776 Oct 4, 2019

플리즈

derilkusuma referenced this pull request Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.