Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move jruby to allow failures matrix #375

Merged
merged 1 commit into from Mar 21, 2019

Conversation

@vipulnsward
Copy link
Contributor

@vipulnsward vipulnsward commented Aug 26, 2018

@vipulnsward vipulnsward changed the title Move jruby to allow failures matrix till crc uint 32 issues are resolved Move jruby to allow failures matrix Aug 26, 2018
@coveralls
Copy link

@coveralls coveralls commented Aug 26, 2018

Coverage Status

Coverage increased (+0.8%) to 99.599% when pulling eda8862 on vipulnsward:allow-jruby-failure-on-crc into e89f6ac on rubyzip:master.

@bdewater bdewater mentioned this pull request Aug 26, 2018
@jdleesmiller
Copy link
Member

@jdleesmiller jdleesmiller commented Mar 21, 2019

Thanks! I am helping Alex out with maintenance now. It looks like this change already landed in #371. I will merge this to make it official. I think we can probably move jruby back now, because the problem has since been fixed.

@jdleesmiller jdleesmiller merged commit d40921b into rubyzip:master Mar 21, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.8%) to 99.599%
Details
This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants